Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1092)

Unified Diff: chrome/browser/component_updater/test/component_updater_service_unittest.cc

Issue 113633006: testrequest is ignored. Also added wow64 attribute. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: moved wow64 to request element. Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/component_updater/test/component_updater_service_unittest.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/component_updater/test/component_updater_service_unittest.cc
diff --git a/chrome/browser/component_updater/test/component_updater_service_unittest.cc b/chrome/browser/component_updater/test/component_updater_service_unittest.cc
index af09125627d2d2fabfde9fc332ae94bd490179e5..1b7589dcb129e6c1f52ff54174b1fb25fcaeb99b 100644
--- a/chrome/browser/component_updater/test/component_updater_service_unittest.cc
+++ b/chrome/browser/component_updater/test/component_updater_service_unittest.cc
@@ -91,7 +91,7 @@ GURL TestConfigurator::PingUrl() {
return UpdateUrl();
}
-const char* TestConfigurator::ExtraRequestParams() { return "extra=foo"; }
+std::string TestConfigurator::ExtraRequestParams() { return "extra=\"foo\""; }
size_t TestConfigurator::UrlSizeLimit() { return 256; }
@@ -473,6 +473,12 @@ TEST_F(ComponentUpdaterTest, InstallCrx) {
"<updatecheck /></app>"))
<< post_interceptor_->GetRequestsAsString();
+ // Test the protocol version is correct and the extra request attributes
+ // are included in the request.
+ EXPECT_NE(string::npos, post_interceptor_->GetRequests()[0].find(
+ "request protocol=\"3.0\" extra=\"foo\""))
+ << post_interceptor_->GetRequestsAsString();
cpu_(ooo_6.6-7.5) 2013/12/17 00:51:05 nice
+
component_updater()->Stop();
}
« no previous file with comments | « chrome/browser/component_updater/test/component_updater_service_unittest.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698