Chromium Code Reviews
Help | Chromium Project | Sign in
(87)

Issue 11363236: Revert 167606 - [Media Gallery][ChromeOS] Improve device media gallery names. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 6 months ago by Hironori Bono
Modified:
2 years, 6 months ago
Reviewers:
kmadhusu
CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org
Visibility:
Public.

Description

Revert 167606 - [Media Gallery][ChromeOS] Improve device media gallery names. (1) When a SD card is attached, report a more generic string like "SD card" on the media permissions dialog. (2) When the attached device is not a SD card or when a sub folder of the device is selected as a media gallery, report the gallery name in the following format: <Device_storage_size> <Selected_sub_folder_gallery_name> <Volume_Name> <(Vendor_Name, Model_Name)> Sample gallery names: (1) 1GB TEST_USB (2) 4GB DCIM - RED_USB (3) 8KB PHOTOS - (TESTCOMPANY, A101) (4) 4GB SD Card (5) 16MB SD Card BUG=159671, 158600 TEST=none Review URL: https://chromiumcodereview.appspot.com/11366144 TBR=kmadhusu@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=167609

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -274 lines) Patch
M chrome/browser/system_monitor/media_device_notifications_utils.h View 2 chunks +0 lines, -10 lines 0 comments Download
M chrome/browser/system_monitor/media_device_notifications_utils.cc View 2 chunks +0 lines, -25 lines 0 comments Download
M chrome/browser/system_monitor/media_storage_util.cc View 2 chunks +11 lines, -21 lines 0 comments Download
M chrome/browser/system_monitor/removable_device_notifications_chromeos.h View 1 chunk +2 lines, -13 lines 0 comments Download
M chrome/browser/system_monitor/removable_device_notifications_chromeos.cc View 7 chunks +30 lines, -51 lines 0 comments Download
M chrome/browser/system_monitor/removable_device_notifications_chromeos_unittest.cc View 10 chunks +25 lines, -139 lines 0 comments Download
M chromeos/disks/mock_disk_mount_manager.h View 2 chunks +1 line, -6 lines 0 comments Download
M chromeos/disks/mock_disk_mount_manager.cc View 2 chunks +5 lines, -9 lines 0 comments Download
Trybot results:
Commit: CQ not working?

Messages

Total messages: 3 (0 generated)
Hironori Bono
2 years, 6 months ago (2012-11-14 06:29:00 UTC) #1
Hironori Bono
Greetings, Apologies for reverting your change. Unfortunately, I have reverted your r167606 because your new ...
2 years, 6 months ago (2012-11-14 06:34:22 UTC) #2
kmadhusu
2 years, 6 months ago (2012-11-14 17:32:41 UTC) #3
On 2012/11/14 06:34:22, Hironori Bono wrote:
> Greetings,
> 
> Apologies for reverting your change. Unfortunately, I have reverted your
r167606
> because your new test RemovableDeviceNotificationsCrosTest.SDCardAttachDetach
> caused a DCHECK failure on the "Linux ChromiumOS Tests (dbg)(1)" bot. (Even
> though your new test appends an absolute path to an SD card
> "/media/removable/Amy_SD" to emulate an SD card, the FilePath::Append function
> does not allow adding it.)
> 
> (*1)
>
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%2520ChromiumOS...
> 
> Regards,
> 
> Hironori Bono

Thanks for reverting my change. Sorry for the inconvenience.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld ec887be