Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(1)

Issue 11363234: google_apis: Remove PostBlockingPoolSequencedTask () and friends (Closed)

Created:
5 years ago by satorux1
Modified:
5 years ago
Reviewers:
hashimoto
CC:
chromium-reviews, nkostylev+watch_chromium.org, tzik+watch_chromium.org, achuith+watch_chromium.org, oshima+watch_chromium.org, kinuko+watch, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

google_apis: Remove PostBlockingPoolSequencedTask () and friends These were introduced to hide some complexity about WaitableEvent (ugh) but the complexity was gone long time ago. There is no need to keep the wrappers. BUG=158495 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=167623

Patch Set 1 #

Patch Set 2 : remove #include #

Total comments: 13

Patch Set 3 : address comments #

Messages

Total messages: 4 (0 generated)
satorux1
5 years ago (2012-11-14 06:23:59 UTC) #1
hashimoto
http://codereview.chromium.org/11363234/diff/4001/chrome/browser/google_apis/gdata_util.h File chrome/browser/google_apis/gdata_util.h (right): http://codereview.chromium.org/11363234/diff/4001/chrome/browser/google_apis/gdata_util.h#newcode10 chrome/browser/google_apis/gdata_util.h:10: #include "base/callback_forward.h" No need to include this. http://codereview.chromium.org/11363234/diff/4001/chrome/browser/google_apis/gdata_util.h#newcode11 chrome/browser/google_apis/gdata_util.h:11: ...
5 years ago (2012-11-14 06:30:17 UTC) #2
satorux1
http://codereview.chromium.org/11363234/diff/4001/chrome/browser/google_apis/gdata_util.h File chrome/browser/google_apis/gdata_util.h (right): http://codereview.chromium.org/11363234/diff/4001/chrome/browser/google_apis/gdata_util.h#newcode9 chrome/browser/google_apis/gdata_util.h:9: added "base/string_piece.h". StringPiece cannot be forward-declared. http://codereview.chromium.org/11363234/diff/4001/chrome/browser/google_apis/gdata_util.h#newcode10 chrome/browser/google_apis/gdata_util.h:10: #include ...
5 years ago (2012-11-14 07:14:30 UTC) #3
hashimoto
5 years ago (2012-11-14 07:21:49 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld efc10ee0f