Chromium Code Reviews
Help | Chromium Project | Sign in
(863)

Issue 11363234: google_apis: Remove PostBlockingPoolSequencedTask () and friends (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 5 months ago by satorux1
Modified:
1 year, 5 months ago
Reviewers:
hashimoto
CC:
chromium-reviews_chromium.org, nkostylev+watch_chromium.org, tzik+watch_chromium.org, achuith+watch_chromium.org, oshima+watch_chromium.org, kinuko+watch, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

google_apis: Remove PostBlockingPoolSequencedTask () and friends

These were introduced to hide some complexity about WaitableEvent (ugh)
but the complexity was gone long time ago. There is no need to keep
the wrappers.

BUG=158495
TEST=none

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=167623

Patch Set 1 #

Patch Set 2 : remove #include #

Total comments: 13

Patch Set 3 : address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -106 lines) Lint Patch
M chrome/browser/chromeos/drive/drive_feed_loader.cc View 4 chunks +4 lines, -8 lines 0 comments ? errors Download
M chrome/browser/chromeos/drive/drive_file_system.cc View 6 chunks +11 lines, -12 lines 0 comments ? errors Download
M chrome/browser/chromeos/drive/file_system/copy_operation.cc View 1 4 chunks +5 lines, -7 lines 0 comments 0 errors Download
M chrome/browser/google_apis/gdata_util.h View 1 2 2 chunks +1 line, -40 lines 0 comments ? errors Download
M chrome/browser/google_apis/gdata_util.cc View 1 2 2 chunks +1 line, -39 lines 0 comments ? errors Download
Commit:

Messages

Total messages: 4
satorux1
1 year, 5 months ago #1
hashimoto
http://codereview.chromium.org/11363234/diff/4001/chrome/browser/google_apis/gdata_util.h File chrome/browser/google_apis/gdata_util.h (right): http://codereview.chromium.org/11363234/diff/4001/chrome/browser/google_apis/gdata_util.h#newcode10 chrome/browser/google_apis/gdata_util.h:10: #include "base/callback_forward.h" No need to include this. http://codereview.chromium.org/11363234/diff/4001/chrome/browser/google_apis/gdata_util.h#newcode11 chrome/browser/google_apis/gdata_util.h:11: ...
1 year, 5 months ago #2
satorux1
http://codereview.chromium.org/11363234/diff/4001/chrome/browser/google_apis/gdata_util.h File chrome/browser/google_apis/gdata_util.h (right): http://codereview.chromium.org/11363234/diff/4001/chrome/browser/google_apis/gdata_util.h#newcode9 chrome/browser/google_apis/gdata_util.h:9: added "base/string_piece.h". StringPiece cannot be forward-declared. http://codereview.chromium.org/11363234/diff/4001/chrome/browser/google_apis/gdata_util.h#newcode10 chrome/browser/google_apis/gdata_util.h:10: #include ...
1 year, 5 months ago #3
hashimoto
1 year, 5 months ago #4
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6