Issue 11363234: google_apis: Remove PostBlockingPoolSequencedTask () and friends

Issue 11363234: google_apis: Remove PostBlockingPoolSequencedTask () and friends (Closed)

Created:
8 years, 1 month ago by satorux1

Modified:
8 years, 1 month ago

Reviewers:
hashimoto

CC:
chromium-reviews, nkostylev+watch_chromium.org, tzik+watch_chromium.org, achuith+watch_chromium.org, oshima+watch_chromium.org, kinuko+watch, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

google_apis: Remove PostBlockingPoolSequencedTask () and friends These were introduced to hide some complexity about WaitableEvent (ugh) but the complexity was gone long time ago. There is no need to keep the wrappers. BUG=158495 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=167623

Patch Set 1 #

Patch Set 2 : remove #include #

Total comments: 13

Patch Set 3 : address comments #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -106 lines)			Patch
M	chrome/browser/chromeos/drive/drive_feed_loader.cc	View		4 chunks	+4 lines, -8 lines	0 comments	Download
M	chrome/browser/chromeos/drive/drive_file_system.cc	View		6 chunks	+11 lines, -12 lines	0 comments	Download
M	chrome/browser/chromeos/drive/file_system/copy_operation.cc	View	1	4 chunks	+5 lines, -7 lines	0 comments	Download
M	chrome/browser/google_apis/gdata_util.h	View	1 2	2 chunks	+1 line, -40 lines	0 comments	Download
M	chrome/browser/google_apis/gdata_util.cc	View	1 2	2 chunks	+1 line, -39 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

hashimoto

http://codereview.chromium.org/11363234/diff/4001/chrome/browser/google_apis/gdata_util.h File chrome/browser/google_apis/gdata_util.h (right): http://codereview.chromium.org/11363234/diff/4001/chrome/browser/google_apis/gdata_util.h#newcode10 chrome/browser/google_apis/gdata_util.h:10: #include "base/callback_forward.h" No need to include this. http://codereview.chromium.org/11363234/diff/4001/chrome/browser/google_apis/gdata_util.h#newcode11 chrome/browser/google_apis/gdata_util.h:11: ...

8 years, 1 month ago (2012-11-14 06:30:17 UTC) #2

satorux1

http://codereview.chromium.org/11363234/diff/4001/chrome/browser/google_apis/gdata_util.h File chrome/browser/google_apis/gdata_util.h (right): http://codereview.chromium.org/11363234/diff/4001/chrome/browser/google_apis/gdata_util.h#newcode9 chrome/browser/google_apis/gdata_util.h:9: added "base/string_piece.h". StringPiece cannot be forward-declared. http://codereview.chromium.org/11363234/diff/4001/chrome/browser/google_apis/gdata_util.h#newcode10 chrome/browser/google_apis/gdata_util.h:10: #include ...

8 years, 1 month ago (2012-11-14 07:14:30 UTC) #3

lgtm

Expand Messages | Collapse Messages