Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issue 11363231: Update README.chromium for gold linker. (Closed)

Created:
8 years, 1 month ago by Sam Clegg
Modified:
8 years, 1 month ago
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/deps/gold.git@master
Visibility:
Public.

Description

Update README.chromium for gold linker. The binaries for gold were already committed in a previous CL. BUG=http://code.google.com/p/chromium/issues/detail?id=127646 r168091

Patch Set 1 #

Patch Set 2 : build on lucid #

Total comments: 1

Patch Set 3 : #

Patch Set 4 : remove binaries #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -6 lines) Patch
M README.chromium View 1 2 1 chunk +16 lines, -6 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
Sam Clegg
8 years, 1 month ago (2012-11-14 03:27:57 UTC) #1
Nico
lgtm Can you link to the gold bug (if you have that at hand)? http://codereview.chromium.org/11363231/diff/2001/README.chromium ...
8 years, 1 month ago (2012-11-14 03:29:25 UTC) #2
robertm
+olonho he might know where that was tracked for binutils On 2012/11/14 03:29:25, Nico wrote: ...
8 years, 1 month ago (2012-11-14 04:05:19 UTC) #3
Nikolay
Sorry couldn't find the bug, but I've certainly seen that it was recently reported/fixed. See ...
8 years, 1 month ago (2012-11-14 12:37:10 UTC) #4
Sam Clegg
On 2012/11/14 12:37:10, olonho wrote: > Sorry couldn't find the bug, but I've certainly seen ...
8 years, 1 month ago (2012-11-14 19:36:25 UTC) #5
Nico
On Wed, Nov 14, 2012 at 11:36 AM, <sbc@chromium.org> wrote: > On 2012/11/14 12:37:10, olonho ...
8 years, 1 month ago (2012-11-14 19:38:28 UTC) #6
Nico
Which gcc did you use to build this? (The binaries are 0.5 MB larger than ...
8 years, 1 month ago (2012-11-15 18:45:24 UTC) #7
Nico
Landed in r167975.
8 years, 1 month ago (2012-11-15 18:49:10 UTC) #8
sbc
Awesome! Thanks. On Thu, Nov 15, 2012 at 10:49 AM, <thakis@chromium.org> wrote: > Landed in ...
8 years, 1 month ago (2012-11-15 20:06:34 UTC) #9
Sam Clegg
On 2012/11/15 20:06:34, sbc wrote: > Awesome! Thanks. > > On Thu, Nov 15, 2012 ...
8 years, 1 month ago (2012-11-15 20:57:43 UTC) #10
Nico
On 2012/11/15 20:57:43, Sam Clegg wrote: > On 2012/11/15 20:06:34, sbc wrote: > > Awesome! ...
8 years, 1 month ago (2012-11-15 21:00:28 UTC) #11
Sam Clegg
On 2012/11/15 21:00:28, Nico wrote: > On 2012/11/15 20:57:43, Sam Clegg wrote: > > On ...
8 years, 1 month ago (2012-11-15 23:34:34 UTC) #12
Nico
On 2012/11/15 23:34:34, Sam Clegg wrote: > Does the CQ work here? I doesn't seem ...
8 years, 1 month ago (2012-11-15 23:36:06 UTC) #13
Nico
8 years, 1 month ago (2012-11-16 00:17:48 UTC) #14
Readme landed in r168091.

By the way, if you just say "BUG=127646", rietveld will auto-link it. If you
want to be explicit, you can say BUG=chromium:127646 (or skia:123, gyp:432,
etc), that way you can link to other projects's bug trackers too.

Powered by Google App Engine
This is Rietveld 408576698