Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3734)

Unified Diff: ash/wm/workspace/multi_window_resize_controller.cc

Issue 11363177: Don't use drag to corner resizing for unresizable windows (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Added more cases and unit tests Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/wm/workspace/multi_window_resize_controller.cc
diff --git a/ash/wm/workspace/multi_window_resize_controller.cc b/ash/wm/workspace/multi_window_resize_controller.cc
index 3a330aa2ca69a6d5f5618cc6f2f7c0bdec020bd4..c9cd180266a7f7ef53eccda547511f7ae3a83cbf 100644
--- a/ash/wm/workspace/multi_window_resize_controller.cc
+++ b/ash/wm/workspace/multi_window_resize_controller.cc
@@ -9,6 +9,7 @@
#include "ash/shell_window_ids.h"
#include "ash/wm/coordinate_conversion.h"
#include "ash/wm/window_animations.h"
+#include "ash/wm/window_util.h"
#include "ash/wm/workspace/workspace_event_handler.h"
#include "ash/wm/workspace/workspace_window_resizer.h"
#include "grit/ash_resources.h"
@@ -286,7 +287,8 @@ Window* MultiWindowResizeController::FindWindowByEdge(
for (Window::Windows::const_reverse_iterator i = windows.rbegin();
i != windows.rend(); ++i) {
Window* window = *i;
- if (window == window_to_ignore || !window->IsVisible())
+ if (window == window_to_ignore || !window->IsVisible() ||
+ !wm::CanResizeWindow(window))
sky 2012/11/13 17:01:54 The multi-window resizer may just move the other w
Mr4D (OOO till 08-26) 2012/11/13 21:27:23 After investigating I have figured out that the fr
continue;
switch (edge_want) {
case HTLEFT:
@@ -326,7 +328,7 @@ aura::Window* MultiWindowResizeController::FindWindowTouching(
for (Window::Windows::const_reverse_iterator i = windows.rbegin();
i != windows.rend(); ++i) {
Window* other = *i;
- if (other == window || !other->IsVisible())
+ if (other == window || !other->IsVisible() || !wm::CanResizeWindow(other))
continue;
switch (direction) {
case TOP_BOTTOM:

Powered by Google App Engine
This is Rietveld 408576698