Don't use drag to corner resizing for unresizable windows

ash/wm/workspace/multi_window_resize_controller.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/wm/workspace/multi_window_resize_controller.h"
 
 #include "ash/screen_ash.h"
 #include "ash/shell.h"
 #include "ash/shell_window_ids.h"
 #include "ash/wm/coordinate_conversion.h"
 #include "ash/wm/window_animations.h"
+#include "ash/wm/window_util.h"
 #include "ash/wm/workspace/workspace_event_handler.h"
 #include "ash/wm/workspace/workspace_window_resizer.h"
 #include "grit/ash_resources.h"
 #include "ui/aura/client/screen_position_client.h"
 #include "ui/aura/event_filter.h"
 #include "ui/aura/root_window.h"
 #include "ui/aura/shared/compound_event_filter.h"
 #include "ui/aura/window.h"
 #include "ui/aura/window_delegate.h"
 #include "ui/base/hit_test.h"
@@ skipping 257 matching lines @@
 Window* MultiWindowResizeController::FindWindowByEdge(
     Window* window_to_ignore,
     int edge_want,
     int x,
     int y) const {
   Window* parent = window_to_ignore->parent();
   const Window::Windows& windows(parent->children());
   for (Window::Windows::const_reverse_iterator i = windows.rbegin();
        i != windows.rend(); ++i) {
     Window* window = *i;
-    if (window == window_to_ignore || !window->IsVisible())
+    if (window == window_to_ignore || !window->IsVisible() ||
+        !wm::CanResizeWindow(window))

[sky, 2012/11/13 17:01:54]

The multi-window resizer may just move the other window, which is fine. It's the
resizing we need to disallow. You'll need to change WorkspaceWindowResizer where
it calculates how and what to resize.

[Mr4D (OOO till 08-26), 2012/11/13 21:27:23]

After investigating I have figured out that the frame_painter.cc's
NonClientHitTest function is not allowing the window to get resized by not
generating the resize handle codes. As a result of that the
multi_window_resize_controller does not include such windows into a sizing
operation. As such I was removing these two test conditions (since they will
never get called) and the unit test for this condition (which will never happen
at this level).

       continue;
     switch (edge_want) {
       case HTLEFT:
         if (ContainsY(window, y) && window->bounds().x() == x)
           return window;
         break;
       case HTRIGHT:
         if (ContainsY(window, y) && window->bounds().right() == x)
           return window;
         break;
@@ skipping 19 matching lines @@
 aura::Window* MultiWindowResizeController::FindWindowTouching(
     aura::Window* window,
     Direction direction) const {
   int right = window->bounds().right();
   int bottom = window->bounds().bottom();
   Window* parent = window->parent();
   const Window::Windows& windows(parent->children());
   for (Window::Windows::const_reverse_iterator i = windows.rbegin();
        i != windows.rend(); ++i) {
     Window* other = *i;
-    if (other == window || !other->IsVisible())
+    if (other == window || !other->IsVisible() || !wm::CanResizeWindow(other))
       continue;
     switch (direction) {
       case TOP_BOTTOM:
         if (other->bounds().y() == bottom &&
             Intersects(other->bounds().x(), other->bounds().right(),
                        window->bounds().x(), window->bounds().right())) {
           return other;
         }
         break;
       case LEFT_RIGHT:
@@ skipping 193 matching lines @@
 
   gfx::Point window_loc(location_in_screen);
   aura::Window::ConvertPointToTarget(
       window->GetRootWindow(), window, &window_loc);
   return window->HitTest(window_loc) &&
       window->delegate()->GetNonClientComponent(window_loc) == component;
 }
 
 }  // namespace internal
 }  // namespace ash