Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(431)

Unified Diff: chrome/test/base/js2gtest.js

Issue 11363170: Add an accessibility audit test for WebUI pages (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 7 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/base/js2gtest.js
diff --git a/chrome/test/base/js2gtest.js b/chrome/test/base/js2gtest.js
index 9ec40a811cb06ccd5a2eca0be60cb1094c4bb111..e6f9461dbf359cb2574583bde39255dc94cb869b 100644
--- a/chrome/test/base/js2gtest.js
+++ b/chrome/test/base/js2gtest.js
@@ -152,7 +152,8 @@ function TEST_F(testFixture, testFunction, testBody) {
var typedefCppFixture = this[testFixture].prototype.typedefCppFixture;
var isAsyncParam = testType === 'unit' ? '' :
this[testFixture].prototype.isAsync + ', ';
- var testShouldFail = this[testFixture].prototype.testShouldFail;
+ var testShouldFail = this[testFixture].prototype.testShouldFail ||
+ testFunction.match(/_shouldFail$/);
Paweł Hajdan Jr. 2013/01/03 21:40:56 Is this really needed? Again, standardize on _one_
aboxhall 2013/01/03 22:11:22 Again, I'm not sure how this is redundant. What sh
scr 2013/01/03 22:18:53 Either subclass and set testShouldFail to true or
aboxhall 2013/01/04 22:26:51 Putting this.testShouldFail = true as the first st
var testPredicate = testShouldFail ? 'ASSERT_FALSE' : 'ASSERT_TRUE';
var extraLibraries = genIncludes.concat(
this[testFixture].prototype.extraLibraries.map(

Powered by Google App Engine
This is Rietveld 408576698