Add an accessibility audit test for WebUI pages

chrome/browser/ui/webui/web_ui_browsertest.h

Index: chrome/browser/ui/webui/web_ui_browsertest.h
diff --git a/chrome/browser/ui/webui/web_ui_browsertest.h b/chrome/browser/ui/webui/web_ui_browsertest.h
index f184570deb369472245840dd3f09436013781bf7..926884929c8301ece14a36e43701aa5291613066 100644
--- a/chrome/browser/ui/webui/web_ui_browsertest.h
+++ b/chrome/browser/ui/webui/web_ui_browsertest.h
@@ -52,6 +52,9 @@ class WebUIBrowserTest
   // as relative to the test data dir.
   void AddLibrary(const FilePath& library_path);
 
+  // Add a helper JS library from a path relative to base::DIR_SOURCE_ROOT.
+  void AddLibraryFromPath(const FilePath& path);

[James Hawkins, 2013/01/03 21:23:39]

How is this different from AddLibrary, which also is 'FromPath' essentially?

[Paweł Hajdan Jr., 2013/01/03 21:40:56]

+1 . Please don't create superfluous public interfaces. Either standardize on
relative paths or absolute paths, but providing both options is a recipe for
mess.

[aboxhall, 2013/01/03 22:11:22]

I don't think it's superfluous. Standardising on relative paths wouldn't work,
since there are some paths that are relative to the test data dir and some that
are relative to base::DIR_SOURCE_ROOT. Standardising on absolute paths would
mean writing code similar to the implementation of this method wherever
AddLibrary() is called.

I agree the name is not terribly helpful - how about AddLibraryFromSourceRoot or
similar?

[James Hawkins, 2013/01/04 18:25:17]

That's fine, but this method does not need to be on this object.  Move it to
unnamed namespace in the implementation file.

[Paweł Hajdan Jr., 2013/01/04 18:57:03]

This effectively says to me, that standardizing wouldn't work since you've not
standardized on a consistent solution. I think this is yet another point that it
would be useful to be consistent.
I don't think playing with the name of this method would be particularly
helpful. One alternative I though about would be a helper somewhere else to
build the DIR_SOURCE_ROOT or other-based paths for you. Just please leave only
_one_ method here in the public interface.

+
   // Runs a javascript function in the context of all libraries.
   // Note that calls to functions in test_api.js are not supported.
   // Takes ownership of Value* arguments.