Chromium Code Reviews
Help | Chromium Project | Sign in
(3)

Issue 11363161: Add CannedSyncableFileSystem::TouchFile for testing (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 4 months ago by kinuko
Modified:
2 years, 4 months ago
Reviewers:
nhiroki, tzik
CC:
chromium-reviews, tzik+watch_chromium.org, kinuko+watch, darin-cc_chromium.org
Visibility:
Public.

Description

Add CannedSyncableFileSystem::TouchFile for testing BUG=none TEST=tests using the method are to be added Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=166884

Patch Set 1 #

Total comments: 6

Patch Set 2 : namig fix #

Messages

Total messages: 4 (0 generated)
nhiroki
lgtm http://codereview.chromium.org/11363161/diff/1/webkit/fileapi/syncable/canned_syncable_file_system.cc File webkit/fileapi/syncable/canned_syncable_file_system.cc (right): http://codereview.chromium.org/11363161/diff/1/webkit/fileapi/syncable/canned_syncable_file_system.cc#newcode454 webkit/fileapi/syncable/canned_syncable_file_system.cc:454: const base::Time& access_time, const base::Time& modified_time, nit: please ...
2 years, 4 months ago (2012-11-09 07:50:03 UTC) #1
kinuko
http://codereview.chromium.org/11363161/diff/1/webkit/fileapi/syncable/canned_syncable_file_system.cc File webkit/fileapi/syncable/canned_syncable_file_system.cc (right): http://codereview.chromium.org/11363161/diff/1/webkit/fileapi/syncable/canned_syncable_file_system.cc#newcode454 webkit/fileapi/syncable/canned_syncable_file_system.cc:454: const base::Time& access_time, const base::Time& modified_time, On 2012/11/09 07:50:03, ...
2 years, 4 months ago (2012-11-09 07:55:33 UTC) #2
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinuko@chromium.org/11363161/12002
2 years, 4 months ago (2012-11-09 08:10:45 UTC) #3
I haz the power (commit-bot)
2 years, 4 months ago (2012-11-09 10:09:29 UTC) #4
Change committed as 166884
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld cf4c24d