[Android WebView] AwContentsClient.shouldCreateWindow callback part 1.

android_webview/browser/aw_content_browser_client.cc

Index: android_webview/browser/aw_content_browser_client.cc
diff --git a/android_webview/browser/aw_content_browser_client.cc b/android_webview/browser/aw_content_browser_client.cc
index 7caa743bc123acbac72edd94ddbdbafc7b49881b..0739269ea2b86fc5621605736afa51d6a41372e1 100644
--- a/android_webview/browser/aw_content_browser_client.cc
+++ b/android_webview/browser/aw_content_browser_client.cc
@@ -237,10 +237,14 @@ bool AwContentBrowserClient::CanCreateWindow(
     content::ResourceContext* context,
     int render_process_id,
     bool* no_javascript_access) {
-  // TODO(boliu): Implement this to power SupportMultipleWindow.
-  NOTIMPLEMENTED();
-  *no_javascript_access = false;
-  return false;
+  // We unconditionally allow popup windows at this stage and will give
+  // the embedder the opporunity to handle displaying of the popup in
+  // WebContentsDelegate::AddContents (via the
+  // AwContentsClient.shouldCreateWindow callback).

[joth, 2012/11/14 18:34:52]

I think Bo's TODO still stands: we want to set this based on
WebSettings.SupportMultipleWindow

[benm (inactive), 2012/11/14 18:42:34]

Will update the TODO with a comment, we won't actually get to this point if the
setting is such that we block the popup (it's checked in webkit).

+  if (no_javascript_access) {
+    *no_javascript_access = false;
+  }
+  return true;
 }
 
 std::string AwContentBrowserClient::GetWorkerProcessTitle(const GURL& url,