[Android WebView] AwContentsClient.shouldCreateWindow callback part 1.

android_webview/browser/aw_content_browser_client.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "android_webview/browser/aw_content_browser_client.h"
 
 #include "android_webview/browser/aw_browser_main_parts.h"
 #include "android_webview/browser/aw_cookie_access_policy.h"
 #include "android_webview/browser/aw_quota_permission_context.h"
 #include "android_webview/browser/net_disk_cache_remover.h"
@@ skipping 219 matching lines @@
   NOTREACHED() << "Android WebView does not support desktop notifications.";
 }
 
 bool AwContentBrowserClient::CanCreateWindow(
     const GURL& opener_url,
     const GURL& source_origin,
     WindowContainerType container_type,
     content::ResourceContext* context,
     int render_process_id,
     bool* no_javascript_access) {
-  // TODO(boliu): Implement this to power SupportMultipleWindow.
-  NOTIMPLEMENTED();
-  *no_javascript_access = false;
-  return false;
+  // We unconditionally allow popup windows at this stage and will give
+  // the embedder the opporunity to handle displaying of the popup in
+  // WebContentsDelegate::AddContents (via the
+  // AwContentsClient.shouldCreateWindow callback).

[joth, 2012/11/14 18:34:52]

I think Bo's TODO still stands: we want to set this based on
WebSettings.SupportMultipleWindow

[benm (inactive), 2012/11/14 18:42:34]

Will update the TODO with a comment, we won't actually get to this point if the
setting is such that we block the popup (it's checked in webkit).

+  if (no_javascript_access) {
+    *no_javascript_access = false;
+  }
+  return true;
 }
 
 std::string AwContentBrowserClient::GetWorkerProcessTitle(const GURL& url,
                                           content::ResourceContext* context) {
   NOTREACHED() << "Android WebView does not yet support web workers.";
   return std::string();
 }
 
 
 void AwContentBrowserClient::ResourceDispatcherHostCreated() {
@@ skipping 57 matching lines @@
 
 bool AwContentBrowserClient::AllowPepperSocketAPI(
     content::BrowserContext* browser_context,
     const GURL& url,
     const content::SocketPermissionRequest& params) {
   NOTREACHED() << "Android WebView does not support plugins";
   return false;
 }
 
 }  // namespace android_webview