Issue 11362061: Fixes crash in unittests. This happened as the result of making the

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11362061: Fixes crash in unittests. This happened as the result of making the (Closed)

Created:
8 years, 1 month ago by sky

Modified:
8 years, 1 month ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fixes crash in unittests. This happened as the result of making the default NativeTheme be NativeThemeWin under aura. Apparently a couple of places (scrollbars for one) are using some types only defined in NativeThemeAura. This patch goes back to defaulting to NativeThemeAura on win-aura. TBR to get win_aura green again. BUG=none TEST=none TBR=ben@chromium.org R=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=165690

Patch Set 1 #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -2 lines)			Patch
	M	ui/base/native_theme/native_theme_aura.cc	View		1 chunk	+0 lines, -2 lines	0 comments	Download
	M	ui/base/native_theme/native_theme_win.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages