Chromium Code Reviews
Help | Chromium Project | Sign in
(222)

Issue 11362061: Fixes crash in unittests. This happened as the result of making the (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 5 months ago by sky
Modified:
1 year, 5 months ago
CC:
chromium-reviews_chromium.org
Visibility:
Public.

Description

Fixes crash in unittests. This happened as the result of making the
default NativeTheme be NativeThemeWin under aura. Apparently a couple
of places (scrollbars for one) are using some types only defined in
NativeThemeAura. This patch goes back to defaulting to NativeThemeAura
on win-aura.

TBR to get win_aura green again.

BUG=none
TEST=none
TBR=ben@chromium.org
R=ben@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=165690

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Lint Patch
M ui/base/native_theme/native_theme_aura.cc View 1 chunk +0 lines, -2 lines 0 comments ? errors Download
M ui/base/native_theme/native_theme_win.cc View 1 chunk +5 lines, -0 lines 0 comments ? errors Download
Trybot results:
Commit:

Messages

Total messages: 2
sky
1 year, 5 months ago #1
Ben Goodger (Google)
1 year, 5 months ago #2
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1275:d14800f88434