Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 11361265: [Spellcheck] Removing cruft. (Closed)

Created:
8 years, 1 month ago by groby-ooo-7-16
Modified:
8 years, 1 month ago
Reviewers:
rpetterson, sky
CC:
chromium-reviews, groby+spellwatch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -95 lines) Patch
M chrome/renderer/chrome_content_renderer_client.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/renderer/chrome_content_renderer_client.cc View 1 chunk +10 lines, -5 lines 0 comments Download
M chrome/renderer/spellchecker/cocoa_spelling_engine_mac.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/renderer/spellchecker/cocoa_spelling_engine_mac.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/renderer/spellchecker/hunspell_engine.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/renderer/spellchecker/spellcheck.h View 2 chunks +7 lines, -0 lines 0 comments Download
M chrome/renderer/spellchecker/spellcheck.cc View 6 chunks +7 lines, -22 lines 0 comments Download
M chrome/renderer/spellchecker/spellcheck_provider.cc View 8 chunks +27 lines, -60 lines 0 comments Download
M chrome/renderer/spellchecker/spellcheck_provider_test.cc View 2 chunks +7 lines, -2 lines 0 comments Download
M chrome/renderer/spellchecker/spellcheck_unittest.cc View 4 chunks +16 lines, -4 lines 0 comments Download
M chrome/renderer/spellchecker/spelling_engine.h View 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/test/base/chrome_render_view_test.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
groby-ooo-7-16
Sorry, re-run of https://codereview.chromium.org/11377045/ Only change is forcing an explicit HunspellEngine for OSX in spellcheck_unittest.cc
8 years, 1 month ago (2012-11-14 22:22:09 UTC) #1
rpetterson
On 2012/11/14 22:22:09, groby wrote: > Sorry, re-run of https://codereview.chromium.org/11377045/ > > Only change is ...
8 years, 1 month ago (2012-11-14 23:07:33 UTC) #2
sky
LGTM
8 years, 1 month ago (2012-11-14 23:25:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/groby@chromium.org/11361265/1
8 years, 1 month ago (2012-11-14 23:30:44 UTC) #4
commit-bot: I haz the power
Retried try job too often for step(s) browser_tests
8 years, 1 month ago (2012-11-15 07:03:35 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/groby@chromium.org/11361265/1
8 years, 1 month ago (2012-11-15 19:47:59 UTC) #6
commit-bot: I haz the power
8 years, 1 month ago (2012-11-15 22:17:52 UTC) #7
Change committed as 168052

Powered by Google App Engine
This is Rietveld 408576698