Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11377045: Removing cruft. (Closed)

Created:
8 years, 1 month ago by groby-ooo-7-16
Modified:
8 years, 1 month ago
Reviewers:
rpetterson, sky
CC:
chromium-reviews, groby+spellwatch_chromium.org, rpetterson, darin-cc_chromium.org
Visibility:
Public.

Description

[Spellcheck] Removing cruft. BUG=154918 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=167563

Patch Set 1 #

Patch Set 2 : Fix compile issue #

Patch Set 3 : Fix mac compile issues. #

Patch Set 4 : Fix broken unit tests. #

Total comments: 2

Patch Set 5 : Address review comment. #

Total comments: 4

Patch Set 6 : Address review nit. #

Patch Set 7 : Fix OSX compile issue. #

Patch Set 8 : #

Patch Set 9 : Next (and final?) round of "fix via trybot" #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -95 lines) Patch
M chrome/renderer/chrome_content_renderer_client.h View 1 2 3 4 5 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/renderer/chrome_content_renderer_client.cc View 1 2 3 4 5 1 chunk +10 lines, -5 lines 0 comments Download
M chrome/renderer/spellchecker/cocoa_spelling_engine_mac.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/renderer/spellchecker/cocoa_spelling_engine_mac.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/renderer/spellchecker/hunspell_engine.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/renderer/spellchecker/spellcheck.h View 1 2 3 4 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/renderer/spellchecker/spellcheck.cc View 1 2 6 chunks +7 lines, -22 lines 0 comments Download
M chrome/renderer/spellchecker/spellcheck_provider.cc View 1 2 3 4 5 6 7 8 8 chunks +27 lines, -60 lines 0 comments Download
M chrome/renderer/spellchecker/spellcheck_provider_test.cc View 2 chunks +7 lines, -2 lines 0 comments Download
M chrome/renderer/spellchecker/spellcheck_unittest.cc View 1 2 3 2 chunks +10 lines, -4 lines 0 comments Download
M chrome/renderer/spellchecker/spelling_engine.h View 1 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/test/base/chrome_render_view_test.cc View 1 2 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
groby-ooo-7-16
8 years, 1 month ago (2012-11-09 18:55:27 UTC) #1
rpetterson
lgtm
8 years, 1 month ago (2012-11-09 19:10:02 UTC) #2
groby-ooo-7-16
sky: Please take a look at chrome_render_view_test,chrome_content_render_client - this CL is injecting a spellchecker for ...
8 years, 1 month ago (2012-11-10 00:01:21 UTC) #3
rpetterson
Still LGTM with one small nit. https://codereview.chromium.org/11377045/diff/6019/chrome/renderer/spellchecker/spellcheck.h File chrome/renderer/spellchecker/spellcheck.h (right): https://codereview.chromium.org/11377045/diff/6019/chrome/renderer/spellchecker/spellcheck.h#newcode41 chrome/renderer/spellchecker/spellcheck.h:41: DONT_MODIFY = 1, ...
8 years, 1 month ago (2012-11-10 00:14:30 UTC) #4
sky
LGTM https://codereview.chromium.org/11377045/diff/1010/chrome/renderer/chrome_content_renderer_client.cc File chrome/renderer/chrome_content_renderer_client.cc (right): https://codereview.chromium.org/11377045/diff/1010/chrome/renderer/chrome_content_renderer_client.cc#newcode988 chrome/renderer/chrome_content_renderer_client.cc:988: nit: remove one line. https://codereview.chromium.org/11377045/diff/1010/chrome/renderer/chrome_content_renderer_client.h File chrome/renderer/chrome_content_renderer_client.h (right): ...
8 years, 1 month ago (2012-11-12 03:51:37 UTC) #5
groby-ooo-7-16
https://codereview.chromium.org/11377045/diff/6019/chrome/renderer/spellchecker/spellcheck.h File chrome/renderer/spellchecker/spellcheck.h (right): https://codereview.chromium.org/11377045/diff/6019/chrome/renderer/spellchecker/spellcheck.h#newcode41 chrome/renderer/spellchecker/spellcheck.h:41: DONT_MODIFY = 1, // Do not modify results. On ...
8 years, 1 month ago (2012-11-13 02:05:15 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/groby@chromium.org/11377045/12014
8 years, 1 month ago (2012-11-13 02:05:36 UTC) #7
commit-bot: I haz the power
Retried try job too often for step(s) unit_tests
8 years, 1 month ago (2012-11-13 03:55:11 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/groby@chromium.org/11377045/12014
8 years, 1 month ago (2012-11-13 18:52:16 UTC) #9
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
8 years, 1 month ago (2012-11-13 19:01:33 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/groby@chromium.org/11377045/12014
8 years, 1 month ago (2012-11-13 20:31:46 UTC) #11
commit-bot: I haz the power
8 years, 1 month ago (2012-11-14 01:08:02 UTC) #12 
Retried try job too often for step(s) unit_tests

Powered by Google App Engine
This is Rietveld 408576698