Issue 11361250: Fix libmtp build. Forgot to apply patches/14_libusb1_header.patch.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11361250: Fix libmtp build. Forgot to apply patches/14_libusb1_header.patch. (Closed)

Created:
8 years, 1 month ago by Lei Zhang

Modified:
8 years, 1 month ago

Reviewers:
Jorge Lucangeli Obes

CC:
chromium-reviews

Base URL:
svn://chrome-svn/chrome/trunk/deps/third_party/libmtp/

Visibility:
Public.

More Reviews

Description

Fix libmtp build. Forgot to apply patches/14_libusb1_header.patch. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=167505

Patch Set 1 #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/libusb-glue.h	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Lei Zhang

Buildbot fail. It's a bit hard to catch this one since some buildbots have the ...

8 years, 1 month ago (2012-11-13 22:59:12 UTC) #1

Jorge Lucangeli Obes

On 2012/11/13 22:59:12, Lei Zhang wrote: > Buildbot fail. It's a bit hard to catch ...

8 years, 1 month ago (2012-11-13 23:01:54 UTC) #2

Lei Zhang

8 years, 1 month ago (2012-11-13 23:07:05 UTC) #3

On 2012/11/13 23:01:54, Jorge Lucangeli Obes wrote:
> On 2012/11/13 22:59:12, Lei Zhang wrote:
> > Buildbot fail. It's a bit hard to catch this one since some buildbots have
the
> > system libusb.h installed, and so does my machine.
> 
> Can we somehow automate carrying the patches forward? Like what we do with
> ebuilds on the Chrome OS side?
> 
> lgtm

Probably, but I have not thought very hard about the problem.

Expand Messages | Collapse Messages