Remove "mixin" from BeginFrameSource/Observer base classes.

Remove "mixin" from BeginFrameSource/Observer base classes.

The term "mixin" strongly suggests that multiple inheritance is used.
But, BeginFrameObserver/Source subclasses never use multiple inheritance.
As multiple inheritance is prohibited by the style guide,
so renaming:
  BeginFrameObserverMixIn -> BeginFrameObserverBase.
  BeginFrameSourceMixIn -> BeginFrameSourceBase

BUG=463196
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/796a5ba46b1adc1de67a3aaa001ef637594cd237
Cr-Commit-Position: refs/heads/master@{#334216}

[deepak.s, 2015-05-19 08:29:46]

deepak.s@samsung.com changed reviewers:
+ mithro@mithis.com, skyostil@chromium.org, sunnyps@chromium.org

[deepak.s, 2015-05-19 08:29:47]

PTAL?
Thanks!

[deepak.s, 2015-05-21 03:03:42]

Ping!

[mithro-old, 2015-05-21 06:06:10]

On 2015/05/21 03:03:42, deepak.s wrote:
> Ping!

LGTM

Sunny you requested this change, can you review and send to the commit queue?

Tim

[deepak.s, 2015-05-26 05:48:30]

@Sunny
Could you please confirm?
Thanks!

[sunnyps, 2015-05-26 21:45:44]

Can you also change the name of BeginFrameSourceMixIn to BeginFrameSourceBase as
a part of this patch?

Please correct the spelling mistakes in the commit message as well and prefix
the commit message with "cc: ".

Thanks!

https://chromiumcodereview.appspot.com/1136123009/diff/1/cc/scheduler/begin_f...
File cc/scheduler/begin_frame_source_unittest.cc (right):

https://chromiumcodereview.appspot.com/1136123009/diff/1/cc/scheduler/begin_f...
cc/scheduler/begin_frame_source_unittest.cc:296: bool
OnBeginFrameMixInDelegate(const BeginFrameArgs& args) override {
Please rename OnBeginFrameMixInDelegate too. I would suggest
OnBeginFrameDerivedImpl or something like that.

[deepak.s, 2015-06-03 04:43:52]

Thanks for the review..
I'll update the patch.

[deepak.s, 2015-06-08 09:28:25]

I have updated the patch and added BeginFrameSourceMixIn changes also.
Please have a look.
Thanks!

[sunnyps, 2015-06-08 17:22:17]

sunnyps@chromium.org changed reviewers:
+ kbr@chromium.org

[sunnyps, 2015-06-08 17:22:19]

Adding kbr@ for content/renderer/gpu review

Please make the commit message: "Remove "mixin" from BeginFrameSource/Observer
base classes." or similar.

Please update the commit description to say that multiple inheritance is
prohibited by the style guide and fix grammatical/spelling mistakes.

Thanks!

https://codereview.chromium.org/1136123009/diff/40001/cc/scheduler/begin_fram...
File cc/scheduler/begin_frame_source.cc (right):

https://codereview.chromium.org/1136123009/diff/40001/cc/scheduler/begin_fram...
cc/scheduler/begin_frame_source.cc:140: // BackToBackBeginFrameSourceBase
--------------------------------------------
This is BackToBackBeginFrameSource - not "Base" or "MixIn".

https://codereview.chromium.org/1136123009/diff/40001/cc/scheduler/begin_fram...
File cc/scheduler/begin_frame_source.h (right):

https://codereview.chromium.org/1136123009/diff/40001/cc/scheduler/begin_fram...
cc/scheduler/begin_frame_source.h:56: // Simple class which implements a
BeginFrameObserver which checks the
"Base class"

[Ken Russell (switch to Gerrit), 2015-06-08 23:15:07]

LGTM assuming sunnyps@ approves this change.

[deepak.s, 2015-06-11 04:04:03]

@sunnyps

PTAL?
Thanks!

[mithro-old, 2015-06-12 13:30:19]

Hi Sunny,

If you are happy with this patch and it passes the trybots I just started it
running on, can you please LGTM and send it to the commit queue?

Thanks!

Tim 'mithro' Ansell

[sunnyps, 2015-06-12 18:53:39]

On 2015/06/12 13:30:19, mithro wrote:
> Hi Sunny,
> 
> If you are happy with this patch and it passes the trybots I just started it
> running on, can you please LGTM and send it to the commit queue?
> 
> Thanks!
> 
> Tim 'mithro' Ansell

LGTM

[sunnyps, 2015-06-12 18:54:51]

sunnyps@chromium.org changed reviewers:
+ boliu@chromium.org

[sunnyps, 2015-06-12 18:54:52]

boliu, Can you please review in_process? Thanks!

[boliu, 2015-06-12 18:56:00]

lgtm

[sunnyps, 2015-06-12 19:01:14]

The CQ bit was checked by sunnyps@chromium.org

[sunnyps, 2015-06-12 19:01:14]

The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org
Link to the patchset: https://chromiumcodereview.appspot.com/1136123009/#ps60001
(title: "updated comments")

[commit-bot: I haz the power, 2015-06-12 19:03:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1136123009/60001

[commit-bot: I haz the power, 2015-06-12 19:08:32]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-06-12 19:09:29]

Patchset 4 (id:??) landed as
https://crrev.com/796a5ba46b1adc1de67a3aaa001ef637594cd237
Cr-Commit-Position: refs/heads/master@{#334216}