Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Side by Side Diff: content/renderer/gpu/compositor_external_begin_frame_source.h

Issue 1136123009: Remove "mixin" from BeginFrameSource/Observer base classes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: updated comments Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/browser/android/in_process/synchronous_compositor_external_begin_frame_source.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_RENDERER_GPU_COMPOSITOR_EXTERNAL_BEGIN_FRAME_SOURCE_H_ 5 #ifndef CONTENT_RENDERER_GPU_COMPOSITOR_EXTERNAL_BEGIN_FRAME_SOURCE_H_
6 #define CONTENT_RENDERER_GPU_COMPOSITOR_EXTERNAL_BEGIN_FRAME_SOURCE_H_ 6 #define CONTENT_RENDERER_GPU_COMPOSITOR_EXTERNAL_BEGIN_FRAME_SOURCE_H_
7 7
8 #include "base/basictypes.h" 8 #include "base/basictypes.h"
9 #include "base/compiler_specific.h" 9 #include "base/compiler_specific.h"
10 #include "base/memory/ref_counted.h" 10 #include "base/memory/ref_counted.h"
11 #include "cc/scheduler/begin_frame_source.h" 11 #include "cc/scheduler/begin_frame_source.h"
12 #include "content/renderer/gpu/compositor_forwarding_message_filter.h" 12 #include "content/renderer/gpu/compositor_forwarding_message_filter.h"
13 13
14 namespace IPC { 14 namespace IPC {
15 class Message; 15 class Message;
16 class SyncMessageFilter; 16 class SyncMessageFilter;
17 } 17 }
18 18
19 namespace content { 19 namespace content {
20 20
21 // This class can be created only on the main thread, but then becomes pinned 21 // This class can be created only on the main thread, but then becomes pinned
22 // to a fixed thread where cc::Scheduler is running. 22 // to a fixed thread where cc::Scheduler is running.
23 class CompositorExternalBeginFrameSource 23 class CompositorExternalBeginFrameSource
24 : public cc::BeginFrameSourceMixIn, 24 : public cc::BeginFrameSourceBase,
25 public NON_EXPORTED_BASE(base::NonThreadSafe) { 25 public NON_EXPORTED_BASE(base::NonThreadSafe) {
26 public: 26 public:
27 explicit CompositorExternalBeginFrameSource( 27 explicit CompositorExternalBeginFrameSource(
28 CompositorForwardingMessageFilter* filter, 28 CompositorForwardingMessageFilter* filter,
29 IPC::SyncMessageFilter* sync_message_filter, 29 IPC::SyncMessageFilter* sync_message_filter,
30 int routing_id); 30 int routing_id);
31 ~CompositorExternalBeginFrameSource() override; 31 ~CompositorExternalBeginFrameSource() override;
32 32
33 // cc::BeginFrameSourceMixIn implementation. 33 // cc::BeginFrameSourceBase implementation.
34 void OnNeedsBeginFramesChange(bool needs_begin_frames) override; 34 void OnNeedsBeginFramesChange(bool needs_begin_frames) override;
35 void SetClientReady() override; 35 void SetClientReady() override;
36 36
37 private: 37 private:
38 class CompositorExternalBeginFrameSourceProxy 38 class CompositorExternalBeginFrameSourceProxy
39 : public base::RefCountedThreadSafe< 39 : public base::RefCountedThreadSafe<
40 CompositorExternalBeginFrameSourceProxy> { 40 CompositorExternalBeginFrameSourceProxy> {
41 public: 41 public:
42 explicit CompositorExternalBeginFrameSourceProxy( 42 explicit CompositorExternalBeginFrameSourceProxy(
43 CompositorExternalBeginFrameSource* begin_frame_source) 43 CompositorExternalBeginFrameSource* begin_frame_source)
(...skipping 25 matching lines...) Expand all
69 scoped_refptr<IPC::SyncMessageFilter> message_sender_; 69 scoped_refptr<IPC::SyncMessageFilter> message_sender_;
70 int routing_id_; 70 int routing_id_;
71 CompositorForwardingMessageFilter::Handler begin_frame_source_filter_handler_; 71 CompositorForwardingMessageFilter::Handler begin_frame_source_filter_handler_;
72 72
73 DISALLOW_COPY_AND_ASSIGN(CompositorExternalBeginFrameSource); 73 DISALLOW_COPY_AND_ASSIGN(CompositorExternalBeginFrameSource);
74 }; 74 };
75 75
76 } // namespace content 76 } // namespace content
77 77
78 #endif // CONTENT_RENDERER_GPU_COMPOSITOR_EXTERNAL_BEGIN_FRAME_SOURCE_H_ 78 #endif // CONTENT_RENDERER_GPU_COMPOSITOR_EXTERNAL_BEGIN_FRAME_SOURCE_H_
OLDNEW
« no previous file with comments | « content/browser/android/in_process/synchronous_compositor_external_begin_frame_source.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698