Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4103)

Unified Diff: chrome/browser/extensions/extension_action.cc

Issue 11361189: Initial skeleton for System Indicator API (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Clean up extension action arguments, style, smaller tests. Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_action.cc
diff --git a/chrome/browser/extensions/extension_action.cc b/chrome/browser/extensions/extension_action.cc
index 09c256e62353a8d30165091d9c6d022da93a1971..a887e1e4e1948229d84f69119afcd68ee28a2c52 100644
--- a/chrome/browser/extensions/extension_action.cc
+++ b/chrome/browser/extensions/extension_action.cc
@@ -28,7 +28,6 @@
#include "ui/gfx/image/image_skia_source.h"
#include "ui/gfx/rect.h"
#include "ui/gfx/size.h"
-#include "ui/gfx/image/image_skia_source.h"
#include "ui/gfx/skbitmap_operations.h"
namespace {
@@ -292,6 +291,9 @@ int ExtensionAction::GetIconSizeForType(
switch (type) {
case extensions::Extension::ActionInfo::TYPE_BROWSER:
case extensions::Extension::ActionInfo::TYPE_PAGE:
+ case extensions::Extension::ActionInfo::TYPE_SYSTEM_INDICATOR:
+ // TODO(dewittj) Report the actual icon size of the system
+ // indicator.
return extension_misc::EXTENSION_ICON_ACTION;
case extensions::Extension::ActionInfo::TYPE_SCRIPT_BADGE:
return extension_misc::EXTENSION_ICON_BITTY;

Powered by Google App Engine
This is Rietveld 408576698