chrome/browser/extensions/browser_event_router.cc - Issue 11361189: Initial skeleton for System Indicator API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/browser_event_router.cc

Issue 11361189: Initial skeleton for System Indicator API (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Clean up extension action arguments, style, smaller tests. Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/browser_event_router.cc

diff --git a/chrome/browser/extensions/browser_event_router.cc b/chrome/browser/extensions/browser_event_router.cc

index 861cfcdcf72bff5993feed6784a0bf73e338da27..11e237c03df72365afc8044d4cdd33f7fb97bd7f 100644

--- a/chrome/browser/extensions/browser_event_router.cc

+++ b/chrome/browser/extensions/browser_event_router.cc

@@ -583,6 +583,9 @@ void BrowserEventRouter::ExtensionActionExecuted(

case Extension::ActionInfo::TYPE_SCRIPT_BADGE:

event_name = "scriptBadge.onClicked";

break;

+ case Extension::ActionInfo::TYPE_SYSTEM_INDICATOR:

+ // The System Indicator handles it's own clicks.

not at google - send to devlin 2012/11/26 19:44:54 it's -> its

dewittj 2012/11/27 01:53:55 Done.

+ break;

}

if (event_name) {