Chromium Code Reviews
Help | Chromium Project | Sign in
(4)

Issue 11361103: msvs: set $(TargetExt) when the "product_extension" is set

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 5 months ago by tootallnate
Modified:
1 year, 5 months ago
Reviewers:
bradn, scottmg
CC:
gyp-developer_googlegroups.com
Visibility:
Public.

Description

msvs: set $(TargetExt) when the "product_extension" is set

For node.js native modules, we set the "product_extension" to "node", so that
the resulting loadable_module has a ".node" file extension. On Windows, doing
this results in a msbuild warning along the lines of:

warning MSB8012: TargetExt(.dll) does not match the Linker's OutputFile
property value (.node). This may cause your project to build incorrectly.
To correct this, please make sure that $(OutDir), $(TargetName) and
$(TargetExt) property values match the value specified in %(Link.OutputFile).

This patch properly sets the $(TargetExt) variable to fix the warning.

BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Lint Patch
M pylib/gyp/generator/msvs.py View 2 chunks +6 lines, -0 lines 0 comments ? errors Download
Trybot results: Sign in to try more bots
Commit:

Issue must be closed to Revert

Messages

Total messages: 3
M-A Ruel
1. You can't use the commit queue for GYP. 2. You need to click "Publish+Mail ...
1 year, 5 months ago #1
tootallnate
On 2012/11/07 13:52:00, Marc-Antoine Ruel wrote: > 1. You can't use the commit queue for ...
1 year, 5 months ago #2
bradn
1 year, 5 months ago #3
Adding scott.
A test of the changed behavior would be idea.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6