Chromium Code Reviews
Help | Chromium Project | Sign in
(661)

Issue 11361057: [cros] Add RecursiveLock for CrOS implementation. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 5 months ago by Ivan Korotkov
Modified:
1 year, 5 months ago
CC:
chromium-reviews_chromium.org
Visibility:
Public.

Description

[cros] Add RecursiveLock for CrOS implementation.


BUG=157348
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=166186

Patch Set 1 #

Patch Set 2 : Enable everywhere for testing #

Patch Set 3 : Lock-less impl #

Patch Set 4 : Revert to CrOS-only #

Patch Set 5 : Merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+186 lines, -80 lines) Lint Patch
A rlz/lib/recursive_lock.h View 1 2 1 chunk +34 lines, -0 lines 0 comments 1 errors Download
A rlz/lib/recursive_lock.cc View 1 2 1 chunk +40 lines, -0 lines 0 comments 1 errors Download
A + rlz/lib/recursive_lock_unittest.cc View 6 chunks +98 lines, -80 lines 0 comments 5 errors Download
M rlz/rlz.gyp View 2 3 4 chunks +14 lines, -0 lines 0 comments ? errors Download
Commit:

Messages

Total messages: 9
Ivan Korotkov
1 year, 5 months ago #1
Dmitry Vyukov
You usually implement recursive mutex as follows. It's much cheaper and faster. class RecursiveLock { ...
1 year, 5 months ago #2
Ivan Korotkov
Thanks! I like your implementation more, updated. Adding Roger for OWNERS approval.
1 year, 5 months ago #3
Dmitry Vyukov
LGTM
1 year, 5 months ago #4
Roger Tawa
lgtm
1 year, 5 months ago #5
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ivankr@chromium.org/11361057/6002
1 year, 5 months ago #6
I haz the power (commit-bot)
Retried try job too often for step(s) content_browsertests
1 year, 5 months ago #7
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ivankr@chromium.org/11361057/7006
1 year, 5 months ago #8
I haz the power (commit-bot)
1 year, 5 months ago #9
Change committed as 166186
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1275:d14800f88434