Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(522)

Issue 1136083003: Revert of Add ETC1 powered SSE encoder for tile texture compression (Closed)

Created:
5 years, 7 months ago by sergeyv
Modified:
5 years, 7 months ago
CC:
cc-bugs_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add ETC1 powered SSE encoder for tile texture compression (patchset #23 id:440001 of https://codereview.chromium.org/1096703002/) Reason for revert: Speculative revert. Looks like this change breaks compilation on win8 GN: http://build.chromium.org/p/chromium.win/builders/Win8%20GN Failure Example: http://build.chromium.org/p/chromium.win/builders/Win8%20GN/builds/7283 Original issue's description: > Add ETC1 powered SSE encoder for tile texture compression > > Created an ETC1 encoder that uses SSE2 to improve compression speed. > The SSE encoder extends TextureCompressor and uses the same algorithm as TextureCompressorETC1. > > Added unittest for TextureCompressorETC1. > > Moved shared code into a etc1 header. > > Added new performance test scenarios. > > Performance difference on Ubuntu x64, Haswell Processor: > Without SSE: > *RESULT Compress256x256BlackAndWhiteGradientImage: ETC1 Low= 1.966321587562561 us > *RESULT Compress256x256SolidBlackImage: ETC1 Low= .0956009104847908 us > *RESULT Compress256x256SolidColorImage: ETC1 Low= .4367307722568512 us > *RESULT Compress256x256RandomColorImage: ETC1 Low= 5.948055744171143 us > > With SSE: > *RESULT Compress256x256BlackAndWhiteGradientImage: ETC1 Low= 1.0316201448440552 us > *RESULT Compress256x256SolidBlackImage: ETC1 Low= .25716209411621094 us > *RESULT Compress256x256SolidColorImage: ETC1 Low= .2768038809299469 us > *RESULT Compress256x256RandomColorImage: ETC1 Low= 1.834145426750183 us > > BUG=434699 > TEST=newly added unittest TextureCompressorETC1Test::Compress256x256CreateETC1, TextureCompressorETC1Test::Compress256x256RatioETC1 > > Committed: https://crrev.com/5f3849aa8307399b7e6dfe5665ed149594244077 > Cr-Commit-Position: refs/heads/master@{#329840} TBR=reveman@chromium.org,christiank@opera.com,jie.a.chen@intel.com,robert.bradford@intel.com,radu.velea@intel.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=434699 Committed: https://crrev.com/4cac9b119cae33bf6277195cec857e97d7111690 Cr-Commit-Position: refs/heads/master@{#329845}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+200 lines, -1213 lines) Patch
M AUTHORS View 1 chunk +0 lines, -1 line 0 comments Download
M cc/BUILD.gn View 3 chunks +0 lines, -32 lines 0 comments Download
M cc/cc.gyp View 2 chunks +0 lines, -37 lines 0 comments Download
M cc/cc_tests.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M cc/resources/texture_compressor.cc View 1 chunk +1 line, -13 lines 0 comments Download
M cc/resources/texture_compressor_etc1.h View 1 chunk +0 lines, -175 lines 0 comments Download
M cc/resources/texture_compressor_etc1.cc View 3 chunks +180 lines, -9 lines 0 comments Download
D cc/resources/texture_compressor_etc1_sse.h View 1 chunk +0 lines, -31 lines 0 comments Download
D cc/resources/texture_compressor_etc1_sse.cc View 1 chunk +0 lines, -821 lines 0 comments Download
D cc/resources/texture_compressor_etc1_unittest.cc View 1 chunk +0 lines, -56 lines 0 comments Download
M cc/resources/texture_compressor_perftest.cc View 4 chunks +19 lines, -37 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
sergeyv
Created Revert of Add ETC1 powered SSE encoder for tile texture compression
5 years, 7 months ago (2015-05-14 14:15:29 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1136083003/1
5 years, 7 months ago (2015-05-14 14:16:11 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-14 14:18:37 UTC) #3
commit-bot: I haz the power
5 years, 7 months ago (2015-05-14 14:19:19 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4cac9b119cae33bf6277195cec857e97d7111690
Cr-Commit-Position: refs/heads/master@{#329845}

Powered by Google App Engine
This is Rietveld 408576698