Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(471)

Issue 11360168: Ensure that full-duplex audio test uses preferred buffer size. (Closed)

Created:
8 years, 1 month ago by henrika (OOO until Aug 14)
Modified:
8 years, 1 month ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Ensure that full-duplex audio test uses preferred buffer size. The existing version does not work on Mac since it uses a hard coded buffer size and that is not allowed by the lower layers. The solution is to use the preferred buffer size instead. BUG=none TEST=media_unittests.exe --gtest_filter=AudioLow* --gtest_also_run_disabled_tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=166906

Patch Set 1 #

Patch Set 2 : Nit #

Total comments: 2

Patch Set 3 : Feedback from Tommi #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -28 lines) Patch
M media/audio/audio_low_latency_input_output_unittest.cc View 1 2 3 chunks +14 lines, -28 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
henrika (OOO until Aug 14)
Please take a look Tommi.
8 years, 1 month ago (2012-11-09 13:06:40 UTC) #1
tommi (sloooow) - chröme
lgtm with a couple of requests. Can you please include the subject in the CL ...
8 years, 1 month ago (2012-11-09 13:20:39 UTC) #2
henrika (OOO until Aug 14)
8 years, 1 month ago (2012-11-09 13:30:57 UTC) #3
Done.

https://codereview.chromium.org/11360168/diff/3001/media/audio/audio_low_late...
File media/audio/audio_low_latency_input_output_unittest.cc (right):

https://codereview.chromium.org/11360168/diff/3001/media/audio/audio_low_late...
media/audio/audio_low_latency_input_output_unittest.cc:295: // Using same buffer
size as for the output side for now.
On 2012/11/09 13:20:39, tommi wrote:
> nit: move this line into the implementation since it doesn't make sense for
the
> caller to know this.

Done.

Powered by Google App Engine
This is Rietveld 408576698