Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(451)

Issue 11360111: [NaCl Addin] Fix building of libraries in MSVS (Closed)

Created:
8 years, 1 month ago by Sam Clegg
Modified:
8 years, 1 month ago
Reviewers:
noelallen1, binji
CC:
native-client-reviews_googlegroups.com
Visibility:
Public.

Description

[NaCl Addin] Fix building of libraries in MSVS. This also adds unit tests that build static and shared libraries so this cannot happen again. I've also added copyright header to all C# files. BUG= Committed: https://code.google.com/p/nativeclient-sdk/source/detail?r=1465

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 6
Unified diffs Side-by-side diffs Delta from patch set Stats (+261 lines, -107 lines) Patch
M visual_studio/NativeClientVSAddIn/InstallerResources/NaCl64/Microsoft.Cpp.NaCl64.targets View 1 2 chunks +2 lines, -2 lines 0 comments Download
M visual_studio/NativeClientVSAddIn/InstallerResources/PNaCl/Microsoft.Cpp.PNaCl.targets View 1 1 chunk +2 lines, -1 line 0 comments Download
M visual_studio/NativeClientVSAddIn/NaCl.Build.CPPTasks/DependencyParser.cs View 1 1 chunk +4 lines, -1 line 0 comments Download
M visual_studio/NativeClientVSAddIn/NaCl.Build.CPPTasks/GCCUtilities.cs View 1 3 chunks +30 lines, -3 lines 1 comment Download
M visual_studio/NativeClientVSAddIn/NaCl.Build.CPPTasks/NaCl.Build.CPPTasks.csproj View 1 1 chunk +1 line, -1 line 0 comments Download
M visual_studio/NativeClientVSAddIn/NaCl.Build.CPPTasks/NaClCompile.cs View 1 6 chunks +17 lines, -8 lines 1 comment Download
M visual_studio/NativeClientVSAddIn/NaCl.Build.CPPTasks/NaClLib.cs View 1 5 chunks +8 lines, -8 lines 0 comments Download
M visual_studio/NativeClientVSAddIn/NaCl.Build.CPPTasks/NaClLink.cs View 1 1 chunk +3 lines, -1 line 0 comments Download
M visual_studio/NativeClientVSAddIn/NaCl.Build.CPPTasks/NaClToolTask.cs View 1 1 chunk +3 lines, -4 lines 0 comments Download
M visual_studio/NativeClientVSAddIn/NaCl.Build.CPPTasks/SDKUtilities.cs View 1 1 chunk +3 lines, -1 line 0 comments Download
M visual_studio/NativeClientVSAddIn/NaCl.Build.CPPTasks/XamlParser.cs View 1 1 chunk +3 lines, -0 lines 0 comments Download
M visual_studio/NativeClientVSAddIn/UnitTests/ComMessageFilter.cs View 1 1 chunk +1 line, -1 line 0 comments Download
A visual_studio/NativeClientVSAddIn/UnitTests/CompileTest.cs View 1 2 1 chunk +182 lines, -0 lines 2 comments Download
M visual_studio/NativeClientVSAddIn/UnitTests/ProjectSettingsTest.cs View 1 2 chunks +0 lines, -74 lines 0 comments Download
M visual_studio/NativeClientVSAddIn/UnitTests/UnitTests.csproj View 1 1 chunk +1 line, -0 lines 0 comments Download
M visual_studio/NativeClientVSAddIn/check_test_results.py View 1 1 chunk +1 line, -2 lines 2 comments Download

Messages

Total messages: 4 (0 generated)
Sam Clegg
Clearly this points to a missing unit test. I guess I'll do that now.
8 years, 1 month ago (2012-11-06 23:02:43 UTC) #1
noelallen1
Removing a variable which the AddIn was not expecting for the Archiving step. LGTM
8 years, 1 month ago (2012-11-07 00:20:55 UTC) #2
Sam Clegg
Significantly changed patch.. now includes unit tests.
8 years, 1 month ago (2012-11-08 00:24:40 UTC) #3
binji
8 years, 1 month ago (2012-11-08 19:13:06 UTC) #4
lgtm w/ comments.

http://codereview.chromium.org/11360111/diff/6001/visual_studio/NativeClientV...
File visual_studio/NativeClientVSAddIn/NaCl.Build.CPPTasks/GCCUtilities.cs
(right):

http://codereview.chromium.org/11360111/diff/6001/visual_studio/NativeClientV...
visual_studio/NativeClientVSAddIn/NaCl.Build.CPPTasks/GCCUtilities.cs:15: ///
Untility functions for dealing with gcc toolchain on windows.
sp: Utility

http://codereview.chromium.org/11360111/diff/6001/visual_studio/NativeClientV...
File visual_studio/NativeClientVSAddIn/NaCl.Build.CPPTasks/NaClCompile.cs
(right):

http://codereview.chromium.org/11360111/diff/6001/visual_studio/NativeClientV...
visual_studio/NativeClientVSAddIn/NaCl.Build.CPPTasks/NaClCompile.cs:241: //
Remove rtti items as they are not relevant in C compilation and will produce
warnings
nit: wrap at 100

http://codereview.chromium.org/11360111/diff/6001/visual_studio/NativeClientV...
File visual_studio/NativeClientVSAddIn/UnitTests/CompileTest.cs (right):

http://codereview.chromium.org/11360111/diff/6001/visual_studio/NativeClientV...
visual_studio/NativeClientVSAddIn/UnitTests/CompileTest.cs:74:
TestUtilities.CleanUpVisualStudioInstance(dte_);
seems strange to have this here. Doesn't this get cleaned up in ClassTearDown?

http://codereview.chromium.org/11360111/diff/6001/visual_studio/NativeClientV...
visual_studio/NativeClientVSAddIn/UnitTests/CompileTest.cs:168:
SetProjectType("Executable", platform);
Is a pepper "executable" a shared library? If it is an actual executable then it
doesn't make much sense to try compiling this -- it can't be run.

http://codereview.chromium.org/11360111/diff/6001/visual_studio/NativeClientV...
File visual_studio/NativeClientVSAddIn/check_test_results.py (right):

http://codereview.chromium.org/11360111/diff/6001/visual_studio/NativeClientV...
visual_studio/NativeClientVSAddIn/check_test_results.py:50: elif exit_code:
exit_code is performing two functions: here it is used to determine if this test
failed...

http://codereview.chromium.org/11360111/diff/6001/visual_studio/NativeClientV...
visual_studio/NativeClientVSAddIn/check_test_results.py:53: return exit_code
here it is used to determine if any test failed.

Unless I've misunderstood this, you probably should use two variables.

Powered by Google App Engine
This is Rietveld 408576698