[NaCl Addin] Fix building of libraries in MSVS

visual_studio/NativeClientVSAddIn/NaCl.Build.CPPTasks/GCCUtilities.cs

-using System;
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+using System;
 using System.Collections.Generic;
 using System.Linq;
 using System.Text;
 
 using System.IO;
 using System.Text.RegularExpressions;
 
 namespace NaCl.Build.CPPTasks
 {
+    /// <summary>
+    /// Untility functions for dealing with gcc toolchain on windows.

[binji, 2012/11/08 19:13:06]

sp: Utility

+    /// </summary>
     class GCCUtilities
     {
         public const int s_CommandLineLength = 256;
 
+        /// <summary>
+        /// Add quotes around a string, if they are needed.
+        /// </summary>
+        /// <returns>The input arg surrounded by quotes as appropriate.</returns>
+        public static string QuoteIfNeeded(string arg)
+        {
+            var match = arg.IndexOfAny(new char[] { ' ', '\t', ';', '&' }) != -1;
+            if (!match)
+                return arg;
+            return "\"" + arg + "\"";
+        }
+
+        /// <summary>
+        /// Convert windows path in to a cygwin path suitable for passing to gcc
+        /// command line.
+        /// </summary>
         public static string ConvertPathWindowsToPosix(string path)
         {
-            return path.Replace('\\', '/');
+            string rtn = path.Replace('\\', '/');
+            rtn = QuoteIfNeeded(rtn);
+            return rtn;
         }
 
         public static string ConvertPathPosixToWindows(string path)
         {
             path = path.Replace('/', '\\');
             // also make double backslashes a single slash
             // TODO: speed this up by iterating instead of two replaces
             return path.Replace("\\\\", "\\");
         }
 
-        // replace GCC error are warning output to Visual Studio format to support going to source code from error output.
+        /// <summary>
+        /// Replace GCC error are warning output to Visual Studio format to
+        /// support going to source code from error output.
+        /// </summary>
         public static string ConvertGCCOutput(string line)
         {
             string result;
             foreach (GCCRegexLineConverter converter in s_RegexConverters)
             {
                 result = converter.Convert(line);
                 if (result.Length > 0)
                 {
                     return result;
                 }
@@ skipping 53 matching lines @@
             },
             new GCCRegexLineConverter
             {
                 OutputExpression =      new Regex(@"^\s*(.?.?[^:]*.*?):(.?.?[^:]*.*?):([1-9]\d*):(.*$)"),
                 FilenameIdentifier =    @"$2",
                 RemainderIdentifier =   @"($3):'$1' $4"
             }
         };
     } // GCCUtilities
 } // namespace