Start calculating new combined NetworkChangeNotifier signal

net/base/network_change_notifier_linux.cc

Index: net/base/network_change_notifier_linux.cc
diff --git a/net/base/network_change_notifier_linux.cc b/net/base/network_change_notifier_linux.cc
index a3753a96c1e27df910e751ae88a95d21ddbedf3f..e491bd82f5a0a220b7fa328056b3dba44ff04fc9 100644
--- a/net/base/network_change_notifier_linux.cc
+++ b/net/base/network_change_notifier_linux.cc
@@ -306,7 +306,8 @@ NetworkChangeNotifierLinux* NetworkChangeNotifierLinux::CreateForTest(
 }
 
 NetworkChangeNotifierLinux::NetworkChangeNotifierLinux(dbus::Bus* bus)
-    : notifier_thread_(new Thread(bus)) {
+    : NetworkChangeNotifier(1500, 500, 1500, 500),

[szym, 2012/11/26 22:17:04]

Just to be clear. I suggest this would be:

namespace {

NetworkChangeNotifier::NetworkChangeCalculatorParams
LinuxNetworkChangeCalculatorParams() {
  NetworkChangeNotifier::NetworkChangeCalculatorParams params;
  params.ip_address_offline_delay = base::TimeDelta::FromMiliseconds(1500);
  // ...
  return params;
}

NetworkChangeNotifierLinux::NetworkChangeNotifierLinux(...)
   : NetworkChangeNotifier(LinuxNetworkChangeCalculatorParams()),
     notifier_thread_(...) {

}


Perhaps NetworkChangeCalculatorParams is too long of a name and since it is an
inner class of NCN it would suffice to call it "CalculatorParams"?

+      notifier_thread_(new Thread(bus)) {
   // We create this notifier thread because the notification implementation
   // needs a MessageLoopForIO, and there's no guarantee that
   // MessageLoop::current() meets that criterion.