Start calculating new combined NetworkChangeNotifier signal

net/base/network_change_notifier_linux.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // This implementation of NetworkChangeNotifier's offline state detection
 // depends on D-Bus and NetworkManager, and is known to work on at least
 // GNOME version 2.30.  If D-Bus or NetworkManager are unavailable, this
 // implementation will always behave as if it is online.
 
 #include "net/base/network_change_notifier_linux.h"
@@ skipping 288 matching lines @@
 NetworkChangeNotifierLinux* NetworkChangeNotifierLinux::Create() {
   return new NetworkChangeNotifierLinux(NULL);
 }
 
 NetworkChangeNotifierLinux* NetworkChangeNotifierLinux::CreateForTest(
     dbus::Bus* bus) {
   return new NetworkChangeNotifierLinux(bus);
 }
 
 NetworkChangeNotifierLinux::NetworkChangeNotifierLinux(dbus::Bus* bus)
-    : notifier_thread_(new Thread(bus)) {
+    : NetworkChangeNotifier(1500, 500, 1500, 500),

[szym, 2012/11/26 22:17:04]

Just to be clear. I suggest this would be:

namespace {

NetworkChangeNotifier::NetworkChangeCalculatorParams
LinuxNetworkChangeCalculatorParams() {
  NetworkChangeNotifier::NetworkChangeCalculatorParams params;
  params.ip_address_offline_delay = base::TimeDelta::FromMiliseconds(1500);
  // ...
  return params;
}

NetworkChangeNotifierLinux::NetworkChangeNotifierLinux(...)
   : NetworkChangeNotifier(LinuxNetworkChangeCalculatorParams()),
     notifier_thread_(...) {

}


Perhaps NetworkChangeCalculatorParams is too long of a name and since it is an
inner class of NCN it would suffice to call it "CalculatorParams"?

+      notifier_thread_(new Thread(bus)) {
   // We create this notifier thread because the notification implementation
   // needs a MessageLoopForIO, and there's no guarantee that
   // MessageLoop::current() meets that criterion.
   base::Thread::Options thread_options(MessageLoop::TYPE_IO, 0);
   notifier_thread_->StartWithOptions(thread_options);
 }
 
 NetworkChangeNotifierLinux::~NetworkChangeNotifierLinux() {
   // Stopping from here allows us to sanity- check that the notifier
   // thread shut down properly.
   notifier_thread_->Stop();
 }
 
 NetworkChangeNotifier::ConnectionType
 NetworkChangeNotifierLinux::GetCurrentConnectionType() const {
   return notifier_thread_->GetCurrentConnectionType();
 }
 
 const internal::AddressTrackerLinux*
 NetworkChangeNotifierLinux::GetAddressTrackerInternal() const {
   return notifier_thread_->address_tracker();
 }
 
 }  // namespace net