Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1208)

Unified Diff: net/android/network_change_notifier_android.cc

Issue 11360108: Start calculating new combined NetworkChangeNotifier signal (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address szym's first round of comments Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/android/network_change_notifier_android.cc
diff --git a/net/android/network_change_notifier_android.cc b/net/android/network_change_notifier_android.cc
index f055af971db4a41bf54e6d386da5c2dc4a2d873e..ef2fe53ea36ed1ced79b9a03edb70ea690276dc9 100644
--- a/net/android/network_change_notifier_android.cc
+++ b/net/android/network_change_notifier_android.cc
@@ -55,7 +55,8 @@ bool NetworkChangeNotifierAndroid::Register(JNIEnv* env) {
return RegisterNativesImpl(env);
}
-NetworkChangeNotifierAndroid::NetworkChangeNotifierAndroid() {
+NetworkChangeNotifierAndroid::NetworkChangeNotifierAndroid()
+ : NetworkChangeNotifier(NetworkChangeCalculatorParamsAndroid()) {
SetConnectionType(CONNECTION_UNKNOWN);
JNIEnv* env = base::android::AttachCurrentThread();
java_network_change_notifier_.Reset(
@@ -65,6 +66,19 @@ NetworkChangeNotifierAndroid::NetworkChangeNotifierAndroid() {
reinterpret_cast<jint>(this)));
}
+// static
+NetworkChangeNotifier::NetworkChangeCalculatorParams
+NetworkChangeNotifierAndroid::NetworkChangeCalculatorParamsAndroid() {
+ NetworkChangeCalculatorParams params;
+ // Only ConnectionTypeChanged signal is produced and no debouncing is needed
+ // so no delay is needed.
szym 2012/11/27 22:22:05 Since this is the case, you don't need any of the
+ params.ip_address_offline_delay_ = base::TimeDelta::FromMilliseconds(0);
+ params.ip_address_online_delay_ = base::TimeDelta::FromMilliseconds(0);
+ params.connection_type_offline_delay_ = base::TimeDelta::FromMilliseconds(0);
+ params.connection_type_online_delay_ = base::TimeDelta::FromMilliseconds(0);
+ return params;
+}
+
void NetworkChangeNotifierAndroid::SetConnectionType(int connection_type) {
base::AutoLock auto_lock(lock_);
connection_type_ = connection_type;

Powered by Google App Engine
This is Rietveld 408576698