chrome/browser/metrics/variations/resource_request_allowed_notifier_unittest.cc - Issue 11360108: Start calculating new combined NetworkChangeNotifier signal

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/metrics/variations/resource_request_allowed_notifier_unittest.cc

Issue 11360108: Start calculating new combined NetworkChangeNotifier signal (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address szym's first round of comments Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chromeos/drive/drive_sync_client_unittest.cc ('K') | « chrome/browser/io_thread.cc ('k') | net/android/network_change_notifier_android.h » ('j') | net/android/network_change_notifier_android.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/metrics/variations/resource_request_allowed_notifier_unittest.cc

diff --git a/chrome/browser/metrics/variations/resource_request_allowed_notifier_unittest.cc b/chrome/browser/metrics/variations/resource_request_allowed_notifier_unittest.cc

index ba8800f9579764960c0cf8c281e2793ec50058a0..1e2f34372f73bd96a287a8f3e7b1bb8f19c7ae9c 100644

--- a/chrome/browser/metrics/variations/resource_request_allowed_notifier_unittest.cc

+++ b/chrome/browser/metrics/variations/resource_request_allowed_notifier_unittest.cc

@@ -14,7 +14,8 @@

class TestNetworkChangeNotifier : public net::NetworkChangeNotifier {

public:

TestNetworkChangeNotifier()

- : net::NetworkChangeNotifier(),

szym 2012/11/27 22:22:05 I'd be okay with a default constructor for the sol

+ : net::NetworkChangeNotifier(

+ net::NetworkChangeNotifier::NetworkChangeCalculatorParams()),

connection_type_to_return_(

net::NetworkChangeNotifier::CONNECTION_UNKNOWN) {

}