Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Issue 1135953004: public org.domokit.sky.shell.SkyMain.ensureInitialized() (Closed)

Created:
5 years, 7 months ago by eukreign
Modified:
5 years, 7 months ago
Reviewers:
abarth-chromium
CC:
gregsimon, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org, yzshen+watch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

public org.domokit.sky.shell.SkyMain.ensureInitialized() It's useful to be able to call org.domokit.sky.shell.SkyMain.ensureInitialized() when implementing custom Android Activities. This commit makes ensureInitialized() public for this purpose. Unrelated changes: Added curly braces to pass PRESUBMIT check. Add Lex Berezhny <lex@damoti.com>; to AUTHORS file in order to be able to commit fixes (and pass PRESUBMIT check). Patch by Lex Berezhny <lex@damoti.com>;. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/1c8761658f8bc5d4111f6db05993b396736b5058

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M AUTHORS View 1 chunk +1 line, -0 lines 0 comments Download
M sky/shell/org/domokit/sky/shell/SkyMain.java View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
abarth-chromium
LGTM Have you signed the Contributor License Agreements? https://www.chromium.org/developers/contributing-code/external-contributor-checklist
5 years, 7 months ago (2015-05-16 18:34:22 UTC) #2
eukreign
On 2015/05/16 18:34:22, abarth wrote: > LGTM > > Have you signed the Contributor License ...
5 years, 7 months ago (2015-05-16 19:42:17 UTC) #3
commit-bot: I haz the power
Commit queue rejected this change because it did not recognize the base URL. Please commit ...
5 years, 7 months ago (2015-05-16 20:54:03 UTC) #6
abarth-chromium
On 2015/05/16 at 19:42:17, lex wrote: > Yes, I signed it as lex@damoti.com. Great. > ...
5 years, 7 months ago (2015-05-16 20:54:18 UTC) #7
abarth-chromium
5 years, 7 months ago (2015-05-16 20:57:47 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1c8761658f8bc5d4111f6db05993b396736b5058 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698