Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 1135933002: [Chromoting] Add GN build support for ar_sample_app target. (Closed)

Created:
5 years, 7 months ago by garykac
Modified:
5 years, 7 months ago
Reviewers:
msw, Jamie
CC:
chromium-reviews, chromoting-reviews_chromium.org, Dirk Pranke
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Chromoting] Add GN build support for ar_sample_app target. This adds GN build rules for the AppRemoting sample app. Some DesktopRemoting build rules were prettified as part of this process (to make the App- and Desktop- remoting build rules more similar). This re-lands crrev.com/1126393002 without any additional changes required. The issues with the GN clobber builds are fixed in crrev.com/1137753002. BUG=471916 Committed: https://crrev.com/581797d8f76d5855b7f0bed1fe912a038d1d7d25 Cr-Commit-Position: refs/heads/master@{#329206}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+450 lines, -137 lines) Patch
M remoting/app_remoting_webapp.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M remoting/app_remoting_webapp_build.gypi View 2 chunks +1 line, -1 line 0 comments Download
M remoting/remoting_client.gypi View 6 chunks +4 lines, -4 lines 0 comments Download
M remoting/remoting_version.gni View 7 chunks +7 lines, -7 lines 0 comments Download
M remoting/webapp/BUILD.gn View 3 chunks +15 lines, -93 lines 0 comments Download
M remoting/webapp/build-webapp.py View 1 chunk +1 line, -1 line 0 comments Download
M remoting/webapp/build_template.gni View 5 chunks +304 lines, -26 lines 0 comments Download
M remoting/webapp/files.gni View 6 chunks +117 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
garykac
5 years, 7 months ago (2015-05-08 23:18:48 UTC) #2
Jamie
Rubber-stamp LGTM.
5 years, 7 months ago (2015-05-08 23:38:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1135933002/1
5 years, 7 months ago (2015-05-11 16:46:45 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-11 18:46:14 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/581797d8f76d5855b7f0bed1fe912a038d1d7d25 Cr-Commit-Position: refs/heads/master@{#329206}
5 years, 7 months ago (2015-05-11 18:48:01 UTC) #7
msw
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1136673003/ by msw@chromium.org. ...
5 years, 7 months ago (2015-05-11 20:21:26 UTC) #8
msw
5 years, 7 months ago (2015-05-11 20:29:31 UTC) #10
Message was sent while issue was closed.
Dirk tracked this down to a merge race with
https://codereview.chromium.org/1133913002

Powered by Google App Engine
This is Rietveld 408576698