Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Issue 1133913002: [Chromoting] Move shared webapp JS files from crd/js -> base/js (Closed)

Created:
5 years, 7 months ago by garykac
Modified:
5 years, 7 months ago
Reviewers:
Jamie
CC:
chromium-reviews, jshin+watch_chromium.org, dcheng, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Chromoting] Move shared webapp JS files from crd/js -> base/js All changes are in the GYPI and GNI files. No changes in the JS files. BUG= Committed: https://crrev.com/43a567e77774c668ade221a36023faaf795fe1df Cr-Commit-Position: refs/heads/master@{#329175}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+192 lines, -11697 lines) Patch
M remoting/app_remoting_webapp_files.gypi View 2 chunks +14 lines, -17 lines 0 comments Download
M remoting/remoting_webapp_files.gypi View 8 chunks +110 lines, -105 lines 0 comments Download
A + remoting/webapp/base/js/activity.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + remoting/webapp/base/js/client_plugin.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + remoting/webapp/base/js/client_plugin_host_desktop_impl.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + remoting/webapp/base/js/client_plugin_impl.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + remoting/webapp/base/js/client_session.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + remoting/webapp/base/js/client_session_factory.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + remoting/webapp/base/js/client_session_factory_unittest.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + remoting/webapp/base/js/client_session_unittest.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + remoting/webapp/base/js/clipboard.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + remoting/webapp/base/js/connected_view.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + remoting/webapp/base/js/connection_info.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + remoting/webapp/base/js/connection_stats.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + remoting/webapp/base/js/credentials_provider.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + remoting/webapp/base/js/dns_blackhole_checker.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + remoting/webapp/base/js/dns_blackhole_checker_unittest.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + remoting/webapp/base/js/error.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + remoting/webapp/base/js/error_unittest.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + remoting/webapp/base/js/fallback_signal_strategy.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + remoting/webapp/base/js/fallback_signal_strategy_unittest.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + remoting/webapp/base/js/format_iq.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + remoting/webapp/base/js/host.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + remoting/webapp/base/js/host_desktop.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + remoting/webapp/base/js/host_settings.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + remoting/webapp/base/js/identity.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + remoting/webapp/base/js/identity_unittest.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + remoting/webapp/base/js/l10n.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + remoting/webapp/base/js/l10n_unittest.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + remoting/webapp/base/js/log_to_server.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + remoting/webapp/base/js/oauth2.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + remoting/webapp/base/js/oauth2_api.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + remoting/webapp/base/js/oauth2_api_impl.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + remoting/webapp/base/js/plugin_settings.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + remoting/webapp/base/js/server_log_entry.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + remoting/webapp/base/js/signal_strategy.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + remoting/webapp/base/js/smart_reconnector.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + remoting/webapp/base/js/stats_accumulator.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + remoting/webapp/base/js/tcp_socket.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + remoting/webapp/base/js/typecheck.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + remoting/webapp/base/js/typecheck_unittest.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + remoting/webapp/base/js/ui_mode.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + remoting/webapp/base/js/wcs_adapter.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + remoting/webapp/base/js/wcs_sandbox_container.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + remoting/webapp/base/js/xhr.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + remoting/webapp/base/js/xhr_unittest.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + remoting/webapp/base/js/xmpp_connection.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + remoting/webapp/base/js/xmpp_connection_unittest.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + remoting/webapp/base/js/xmpp_login_handler.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + remoting/webapp/base/js/xmpp_login_handler_unittest.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + remoting/webapp/base/js/xmpp_stream_parser.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + remoting/webapp/base/js/xmpp_stream_parser_unittest.js View 0 chunks +-1 lines, --1 lines 0 comments Download
D remoting/webapp/crd/js/activity.js View 1 chunk +0 lines, -38 lines 0 comments Download
D remoting/webapp/crd/js/client_plugin.js View 1 chunk +0 lines, -262 lines 0 comments Download
D remoting/webapp/crd/js/client_plugin_host_desktop_impl.js View 1 chunk +0 lines, -126 lines 0 comments Download
D remoting/webapp/crd/js/client_plugin_impl.js View 1 chunk +0 lines, -911 lines 0 comments Download
D remoting/webapp/crd/js/client_session.js View 1 chunk +0 lines, -607 lines 0 comments Download
D remoting/webapp/crd/js/client_session_factory.js View 1 chunk +0 lines, -134 lines 0 comments Download
D remoting/webapp/crd/js/client_session_factory_unittest.js View 1 chunk +0 lines, -95 lines 0 comments Download
D remoting/webapp/crd/js/client_session_unittest.js View 1 chunk +0 lines, -176 lines 0 comments Download
D remoting/webapp/crd/js/clipboard.js View 1 chunk +0 lines, -215 lines 0 comments Download
D remoting/webapp/crd/js/connected_view.js View 1 chunk +0 lines, -198 lines 0 comments Download
D remoting/webapp/crd/js/connection_info.js View 1 chunk +0 lines, -55 lines 0 comments Download
D remoting/webapp/crd/js/connection_stats.js View 1 chunk +0 lines, -137 lines 0 comments Download
D remoting/webapp/crd/js/credentials_provider.js View 1 chunk +0 lines, -99 lines 0 comments Download
D remoting/webapp/crd/js/dns_blackhole_checker.js View 1 chunk +0 lines, -193 lines 0 comments Download
D remoting/webapp/crd/js/dns_blackhole_checker_unittest.js View 1 chunk +0 lines, -197 lines 0 comments Download
D remoting/webapp/crd/js/error.js View 1 chunk +0 lines, -170 lines 0 comments Download
D remoting/webapp/crd/js/error_unittest.js View 1 chunk +0 lines, -112 lines 0 comments Download
D remoting/webapp/crd/js/fallback_signal_strategy.js View 1 chunk +0 lines, -357 lines 0 comments Download
D remoting/webapp/crd/js/fallback_signal_strategy_unittest.js View 1 chunk +0 lines, -302 lines 0 comments Download
D remoting/webapp/crd/js/format_iq.js View 1 chunk +0 lines, -698 lines 0 comments Download
D remoting/webapp/crd/js/host.js View 1 chunk +0 lines, -123 lines 0 comments Download
D remoting/webapp/crd/js/host_desktop.js View 1 chunk +0 lines, -51 lines 0 comments Download
D remoting/webapp/crd/js/host_settings.js View 1 chunk +0 lines, -105 lines 0 comments Download
D remoting/webapp/crd/js/identity.js View 1 chunk +0 lines, -247 lines 0 comments Download
D remoting/webapp/crd/js/identity_unittest.js View 1 chunk +0 lines, -149 lines 0 comments Download
D remoting/webapp/crd/js/l10n.js View 1 chunk +0 lines, -106 lines 0 comments Download
D remoting/webapp/crd/js/l10n_unittest.js View 1 chunk +0 lines, -112 lines 0 comments Download
D remoting/webapp/crd/js/log_to_server.js View 1 chunk +0 lines, -289 lines 0 comments Download
D remoting/webapp/crd/js/oauth2.js View 1 chunk +0 lines, -450 lines 0 comments Download
D remoting/webapp/crd/js/oauth2_api.js View 1 chunk +0 lines, -81 lines 0 comments Download
D remoting/webapp/crd/js/oauth2_api_impl.js View 1 chunk +0 lines, -243 lines 0 comments Download
D remoting/webapp/crd/js/plugin_settings.js View 1 chunk +0 lines, -83 lines 0 comments Download
D remoting/webapp/crd/js/server_log_entry.js View 1 chunk +0 lines, -510 lines 0 comments Download
D remoting/webapp/crd/js/signal_strategy.js View 1 chunk +0 lines, -123 lines 0 comments Download
D remoting/webapp/crd/js/smart_reconnector.js View 1 chunk +0 lines, -126 lines 0 comments Download
D remoting/webapp/crd/js/stats_accumulator.js View 1 chunk +0 lines, -124 lines 0 comments Download
D remoting/webapp/crd/js/tcp_socket.js View 1 chunk +0 lines, -200 lines 0 comments Download
D remoting/webapp/crd/js/typecheck.js View 1 chunk +0 lines, -249 lines 0 comments Download
D remoting/webapp/crd/js/typecheck_unittest.js View 1 chunk +0 lines, -240 lines 0 comments Download
D remoting/webapp/crd/js/ui_mode.js View 1 chunk +0 lines, -288 lines 0 comments Download
D remoting/webapp/crd/js/wcs_adapter.js View 1 chunk +0 lines, -155 lines 0 comments Download
D remoting/webapp/crd/js/wcs_sandbox_container.js View 1 chunk +0 lines, -286 lines 0 comments Download
D remoting/webapp/crd/js/xhr.js View 1 chunk +0 lines, -395 lines 0 comments Download
D remoting/webapp/crd/js/xhr_unittest.js View 1 chunk +0 lines, -405 lines 0 comments Download
D remoting/webapp/crd/js/xmpp_connection.js View 1 chunk +0 lines, -341 lines 0 comments Download
D remoting/webapp/crd/js/xmpp_connection_unittest.js View 1 chunk +0 lines, -125 lines 0 comments Download
D remoting/webapp/crd/js/xmpp_login_handler.js View 1 chunk +0 lines, -298 lines 0 comments Download
D remoting/webapp/crd/js/xmpp_login_handler_unittest.js View 1 chunk +0 lines, -178 lines 0 comments Download
D remoting/webapp/crd/js/xmpp_stream_parser.js View 1 chunk +0 lines, -258 lines 0 comments Download
D remoting/webapp/crd/js/xmpp_stream_parser_unittest.js View 1 chunk +0 lines, -96 lines 0 comments Download
M remoting/webapp/files.gni View 8 chunks +118 lines, -107 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
garykac
5 years, 7 months ago (2015-05-08 23:00:25 UTC) #2
Jamie
LGTM. Thanks for doing this!
5 years, 7 months ago (2015-05-08 23:40:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1133913002/1
5 years, 7 months ago (2015-05-08 23:56:24 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) android_chromium_gn_compile_rel on ...
5 years, 7 months ago (2015-05-09 03:29:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1133913002/1
5 years, 7 months ago (2015-05-11 16:46:32 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-11 17:48:48 UTC) #10
commit-bot: I haz the power
5 years, 7 months ago (2015-05-11 17:50:23 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/43a567e77774c668ade221a36023faaf795fe1df
Cr-Commit-Position: refs/heads/master@{#329175}

Powered by Google App Engine
This is Rietveld 408576698