Update NSS to NSS 3.14 pre-release snapshot 2012-06-26 01:00:00 PDT.

Update NSS to NSS 3.14 pre-release snapshot 2012-06-26 01:00:00 PDT.

This is the snapshot of NSS right before the NSS patch for
https://bugzilla.mozilla.org/show_bug.cgi?id=753116 (softoken needs
to split out common components to util) was checked in, which we
suspect may have caused the crash in bug 153281.

TBR=rsleevi@chromium.org
BUG=151692
TEST=none
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=166571

[wtc, 2012-11-07 22:12:33]

I'm going to narrow down the NSS checkin that causes the
crash in bug 153281. The comments below are the minor issues
I noticed when I reviewed the changes in this NSS snapshot.

https://codereview.chromium.org/11359091/diff/1/mozilla/security/nss/lib/free...
File mozilla/security/nss/lib/freebl/shvfy.c (right):

https://codereview.chromium.org/11359091/diff/1/mozilla/security/nss/lib/free...
mozilla/security/nss/lib/freebl/shvfy.c:491: if (hashObj) {

This null test for hashObj seems unnecessary.

https://codereview.chromium.org/11359091/diff/1/mozilla/security/nss/lib/pk11...
File mozilla/security/nss/lib/pk11wrap/pk11auth.c (right):

https://codereview.chromium.org/11359091/diff/1/mozilla/security/nss/lib/pk11...
mozilla/security/nss/lib/pk11wrap/pk11auth.c:79: /* TODO If it was for
CKU_CONTEXT_SPECIFIC should we do this */

Indentation looks wrong.

https://codereview.chromium.org/11359091/diff/1/mozilla/security/nss/lib/pk11...
File mozilla/security/nss/lib/pk11wrap/pk11obj.c (right):

https://codereview.chromium.org/11359091/diff/1/mozilla/security/nss/lib/pk11...
mozilla/security/nss/lib/pk11wrap/pk11obj.c:762: }

The indentation is wrong when tab stop is 8 (the NSS default).

https://codereview.chromium.org/11359091/diff/1/mozilla/security/nss/lib/pk11...
File mozilla/security/nss/lib/pk11wrap/pk11skey.c (right):

https://codereview.chromium.org/11359091/diff/1/mozilla/security/nss/lib/pk11...
mozilla/security/nss/lib/pk11wrap/pk11skey.c:1807: return NULL;

We should call PORT_SetError(SEC_ERROR_UNSUPPORTED_EC_POINT_FORM) here.

https://codereview.chromium.org/11359091/diff/1/mozilla/security/nss/lib/pk11...
mozilla/security/nss/lib/pk11wrap/pk11skey.c:1827:
PORT_SetError(SEC_ERROR_INVALID_ALGORITHM);

We should call PK11_FreeSymKey(symKey) here.

https://codereview.chromium.org/11359091/diff/1/mozilla/security/nss/lib/pk11...
File mozilla/security/nss/lib/pk11wrap/pk11util.c (right):

https://codereview.chromium.org/11359091/diff/1/mozilla/security/nss/lib/pk11...
mozilla/security/nss/lib/pk11wrap/pk11util.c:1085: if ((mod->slotCount !=0) &&
!removableSlotsFound) {

Hmm... I don't remember reviewing the changes to this file, even
though rrelyea said r=wtc.

http://bonsai.mozilla.org/cvslog.cgi?file=mozilla/security/nss/lib/pk11wrap/p...

https://codereview.chromium.org/11359091/diff/1/mozilla/security/nss/lib/soft...
File mozilla/security/nss/lib/softoken/pkcs11c.c (right):

https://codereview.chromium.org/11359091/diff/1/mozilla/security/nss/lib/soft...
mozilla/security/nss/lib/softoken/pkcs11c.c:2989: 

Should remove these blank lines.

https://codereview.chromium.org/11359091/diff/1/mozilla/security/nss/lib/util...
File mozilla/security/nss/lib/util/pkcs11t.h (right):

https://codereview.chromium.org/11359091/diff/1/mozilla/security/nss/lib/util...
mozilla/security/nss/lib/util/pkcs11t.h:1272: #define CKD_SHA224_KDF          
0x00000005

Would be nice to add 3 and 4.

[wtc, 2012-11-08 01:57:36]

https://codereview.chromium.org/11359091/diff/1067/mozilla/security/nss/lib/c...
File mozilla/security/nss/lib/cryptohi/secvfy.c (right):

https://codereview.chromium.org/11359091/diff/1067/mozilla/security/nss/lib/c...
mozilla/security/nss/lib/cryptohi/secvfy.c:105: /* the full DSA signature... 40
bytes */

"40 bytes" should be updated.