Lazy initialization for ProcessesEventRouter.

chrome/browser/extensions/extension_system.cc

Index: chrome/browser/extensions/extension_system.cc
diff --git a/chrome/browser/extensions/extension_system.cc b/chrome/browser/extensions/extension_system.cc
index cf5b5d451641efe65d414bd09684c4c30aefa38b..2168a13db186f5c949d3f287ff6609f0734363ff 100644
--- a/chrome/browser/extensions/extension_system.cc
+++ b/chrome/browser/extensions/extension_system.cc
@@ -13,6 +13,7 @@
 #include "chrome/browser/extensions/api/alarms/alarm_manager.h"
 #include "chrome/browser/extensions/api/declarative/rules_registry_service.h"
 #include "chrome/browser/extensions/api/messaging/message_service.h"
+#include "chrome/browser/extensions/api/processes/processes_api_service.h"
 #include "chrome/browser/extensions/component_loader.h"
 #include "chrome/browser/extensions/event_router.h"
 #include "chrome/browser/extensions/extension_devtools_manager.h"
@@ -71,6 +72,7 @@ ExtensionSystem* ExtensionSystem::Get(Profile* profile) {
 
 ExtensionSystemImpl::Shared::Shared(Profile* profile)
     : profile_(profile) {
+
 }
 
 ExtensionSystemImpl::Shared::~Shared() {
@@ -112,6 +114,11 @@ void ExtensionSystemImpl::Shared::Init(bool extensions_enabled) {
 
   user_script_master_ = new UserScriptMaster(profile_);
 
+  // Initialize services that register with the event router.
+  // TODO(yoz): crbug.com/159265: This shouldn't be here, because of dependency
+  // issues, but unfortunately extension startup ordering is complicated.
+  ProcessesAPIService::Get(profile_);

[Yoyo Zhou, 2012/11/07 03:25:19]

This is the unfortunate part.

The observers are registered with EventRouter (for logically they belong there).
But EventRouter isn't initialized until relatively late in profile startup,
along with most of the extensions stuff. Meanwhile, PKSF only can change the
order of PKS construction, so the ProcessesAPIService can either be created on
demand (here) or right after ExtensionSystem is constructed.

The most obvious solution is to register observers with ExtensionSystem instead,
but I'm not sure if the observer map should live there, or if the registrations
should merely be stashed until EventRouter comes alive.

[Aaron Boodman, 2012/11/07 04:08:20]

Move EventRouter construction into ExtensionSystem construction?

[Yoyo Zhou, 2012/11/07 22:53:36]

This turned out to be the best solution. I had to clean up some other detritus
in EventRouter to do so, but it was worth it.

+
   bool autoupdate_enabled = true;
 #if defined(OS_CHROMEOS)
   if (!extensions_enabled)