Lazy initialization for ProcessesEventRouter.

chrome/browser/extensions/extension_system.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_system.h"
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/file_path.h"
 #include "base/string_tokenizer.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/content_settings/cookie_settings.h"
 #include "chrome/browser/extensions/api/alarms/alarm_manager.h"
 #include "chrome/browser/extensions/api/declarative/rules_registry_service.h"
 #include "chrome/browser/extensions/api/messaging/message_service.h"
+#include "chrome/browser/extensions/api/processes/processes_api_service.h"
 #include "chrome/browser/extensions/component_loader.h"
 #include "chrome/browser/extensions/event_router.h"
 #include "chrome/browser/extensions/extension_devtools_manager.h"
 #include "chrome/browser/extensions/extension_error_reporter.h"
 #include "chrome/browser/extensions/extension_info_map.h"
 #include "chrome/browser/extensions/extension_pref_store.h"
 #include "chrome/browser/extensions/extension_pref_value_map.h"
 #include "chrome/browser/extensions/extension_pref_value_map_factory.h"
 #include "chrome/browser/extensions/extension_process_manager.h"
 #include "chrome/browser/extensions/extension_service.h"
@@ skipping 38 matching lines @@
 ExtensionSystem* ExtensionSystem::Get(Profile* profile) {
   return ExtensionSystemFactory::GetForProfile(profile);
 }
 
 //
 // ExtensionSystemImpl::Shared
 //
 
 ExtensionSystemImpl::Shared::Shared(Profile* profile)
     : profile_(profile) {
+
 }
 
 ExtensionSystemImpl::Shared::~Shared() {
 }
 
 void ExtensionSystemImpl::Shared::InitPrefs() {
   bool extensions_disabled =
       profile_->GetPrefs()->GetBoolean(prefs::kDisableExtensions) ||
       CommandLine::ForCurrentProcess()->HasSwitch(switches::kDisableExtensions);
   extension_prefs_.reset(new ExtensionPrefs(
@@ skipping 21 matching lines @@
   lazy_background_task_queue_.reset(new LazyBackgroundTaskQueue(profile_));
   message_service_.reset(new MessageService(lazy_background_task_queue_.get()));
   extension_event_router_.reset(new EventRouter(profile_,
                                                 extension_prefs_.get()));
   navigation_observer_.reset(new NavigationObserver(profile_));
 
   ExtensionErrorReporter::Init(true);  // allow noisy errors.
 
   user_script_master_ = new UserScriptMaster(profile_);
 
+  // Initialize services that register with the event router.
+  // TODO(yoz): crbug.com/159265: This shouldn't be here, because of dependency
+  // issues, but unfortunately extension startup ordering is complicated.
+  ProcessesAPIService::Get(profile_);

[Yoyo Zhou, 2012/11/07 03:25:19]

This is the unfortunate part.

The observers are registered with EventRouter (for logically they belong there).
But EventRouter isn't initialized until relatively late in profile startup,
along with most of the extensions stuff. Meanwhile, PKSF only can change the
order of PKS construction, so the ProcessesAPIService can either be created on
demand (here) or right after ExtensionSystem is constructed.

The most obvious solution is to register observers with ExtensionSystem instead,
but I'm not sure if the observer map should live there, or if the registrations
should merely be stashed until EventRouter comes alive.

[Aaron Boodman, 2012/11/07 04:08:20]

Move EventRouter construction into ExtensionSystem construction?

[Yoyo Zhou, 2012/11/07 22:53:36]

This turned out to be the best solution. I had to clean up some other detritus
in EventRouter to do so, but it was worth it.

+
   bool autoupdate_enabled = true;
 #if defined(OS_CHROMEOS)
   if (!extensions_enabled)
     autoupdate_enabled = false;
   else
     autoupdate_enabled = !command_line->HasSwitch(switches::kGuestSession);
 #endif
   extension_service_.reset(new ExtensionService(
       profile_,
       CommandLine::ForCurrentProcess(),
@@ skipping 268 matching lines @@
 void ExtensionSystemImpl::UnregisterExtensionWithRequestContexts(
     const std::string& extension_id,
     const extension_misc::UnloadedExtensionReason reason) {
   BrowserThread::PostTask(
       BrowserThread::IO, FROM_HERE,
       base::Bind(&ExtensionInfoMap::RemoveExtension, info_map(),
                  extension_id, reason));
 }
 
 }  // namespace extensions