Chromium Code Reviews
Help | Chromium Project | Sign in
(11)

Issue 11359044: Add support for ProgramDatabaseFile to Ninja (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 4 months ago by noelallen1
Modified:
2 years, 4 months ago
Reviewers:
iannucci, scottmg
CC:
gyp-developer_googlegroups.com
Visibility:
Public.

Description

Add support for ProgramDatabaseFile to Ninja Currently we ignore the ProgramDatabaseFile option in the linker portion of the GYP file. This change will cause the /PDB:<name> switch to be emitted during the link step as part of ldflags. Since ldflags are appended to the defaults, they override any default /PDB switches that are current emitted which is consistent with our current uses. BUG=126499 TEST=gyptest-link-pdb Committed: https://code.google.com/p/gyp/source/detail?r=1530

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -0 lines) Patch
M pylib/gyp/msvs_emulation.py View 1 chunk +1 line, -0 lines 0 comments Download
A test/win/gyptest-link-pdb.py View 1 chunk +32 lines, -0 lines 0 comments Download
A test/win/linker-flags/program-database.gyp View 1 chunk +23 lines, -0 lines 2 comments Download
Commit: CQ not working?

Messages

Total messages: 5 (0 generated)
noelallen1
2 years, 4 months ago (2012-11-02 19:15:45 UTC) #1
scottmg
lgtm
2 years, 4 months ago (2012-11-02 19:27:01 UTC) #2
iannucci
lgtm, just a typo https://chromiumcodereview.appspot.com/11359044/diff/1/test/win/linker-flags/program-database.gyp File test/win/linker-flags/program-database.gyp (right): https://chromiumcodereview.appspot.com/11359044/diff/1/test/win/linker-flags/program-database.gyp#newcode7 test/win/linker-flags/program-database.gyp:7: # Verify that 'ProgramDataBase' option ...
2 years, 4 months ago (2012-11-02 21:09:34 UTC) #3
iannucci
On 2012/11/02 21:09:34, iannucci wrote: > lgtm, just a typo > > https://chromiumcodereview.appspot.com/11359044/diff/1/test/win/linker-flags/program-database.gyp > File ...
2 years, 4 months ago (2012-11-02 21:10:05 UTC) #4
noelallen1
2 years, 4 months ago (2012-11-03 00:49:41 UTC) #5
http://codereview.chromium.org/11359044/diff/1/test/win/linker-flags/program-...
File test/win/linker-flags/program-database.gyp (right):

http://codereview.chromium.org/11359044/diff/1/test/win/linker-flags/program-...
test/win/linker-flags/program-database.gyp:7: # Verify that 'ProgramDataBase'
option correctly makes it to LINK steup in Ninja
Fixing in new CL:
https://codereview.chromium.org/11368059

On 2012/11/02 21:09:34, iannucci wrote:
> steup -> typo?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld ecdb341-tainted