Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(1)

Issue 11368059: Update ProgramDatabaseFile for Ninja (Closed)

Created:
5 years, 1 month ago by noelallen1
Modified:
5 years, 1 month ago
Reviewers:
scottmg
CC:
gyp-developer_googlegroups.com
Visibility:
Public.

Description

Update ProgramDatabaseFile for Ninja Replace simple text with OutputFile style expansion to handle cases where $(OutDir) or other VS Macros are used. R=scottmg@chromium.org Committed: https://code.google.com/p/gyp/source/detail?r=1532

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -7 lines) Patch
M pylib/gyp/msvs_emulation.py View 1 2 3 3 chunks +13 lines, -1 line 0 comments Download
M test/win/gyptest-link-pdb.py View 1 2 3 1 chunk +5 lines, -3 lines 0 comments Download
M test/win/linker-flags/program-database.gyp View 1 2 3 2 chunks +19 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
noelallen1
5 years, 1 month ago (2012-11-02 22:29:03 UTC) #1
scottmg
is this the same as the other one? lgtm https://codereview.chromium.org/11368059/diff/1/pylib/gyp/msvs_emulation.py File pylib/gyp/msvs_emulation.py (right): https://codereview.chromium.org/11368059/diff/1/pylib/gyp/msvs_emulation.py#newcode283 pylib/gyp/msvs_emulation.py:283: ...
5 years, 1 month ago (2012-11-02 22:32:36 UTC) #2
noelallen1
5 years, 1 month ago (2012-11-02 23:18:23 UTC) #3
http://codereview.chromium.org/11368059/diff/1/pylib/gyp/msvs_emulation.py
File pylib/gyp/msvs_emulation.py (right):

http://codereview.chromium.org/11368059/diff/1/pylib/gyp/msvs_emulation.py#ne...
pylib/gyp/msvs_emulation.py:283: config = self._RealConfig(config)
On 2012/11/02 22:32:36, scottmg wrote:
> remove

I don't need the _RealConfig in this case since the one place GetPDBName gets
called from calls it for me.  However if this function where used somewhere else
it may fail.

Powered by Google App Engine
This is Rietveld 0eb02b776