Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 11359043: Added PAM configuration. (Closed)

Created:
8 years, 1 month ago by Jamie
Modified:
8 years, 1 month ago
Reviewers:
Lambros
CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, rmsousa+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : Added copyright. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
A + remoting/host/installer/linux/debian/chrome-remote-desktop.pam View 1 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Jamie
ptal
8 years, 1 month ago (2012-11-02 18:30:52 UTC) #1
Lambros
lgtm http://codereview.chromium.org/11359043/diff/1/remoting/host/installer/linux/debian/chrome-remote-desktop.pam File remoting/host/installer/linux/debian/chrome-remote-desktop.pam (right): http://codereview.chromium.org/11359043/diff/1/remoting/host/installer/linux/debian/chrome-remote-desktop.pam#newcode1 remoting/host/installer/linux/debian/chrome-remote-desktop.pam:1: # We fall back to the system default ...
8 years, 1 month ago (2012-11-02 21:40:31 UTC) #2
Jamie
Done. The comment was essentially copied from pam.d/other, which is what this file was based ...
8 years, 1 month ago (2012-11-03 00:45:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamiewalch@chromium.org/11359043/5001
8 years, 1 month ago (2012-11-03 00:47:10 UTC) #4
commit-bot: I haz the power
Retried try job too often for step(s) content_browsertests
8 years, 1 month ago (2012-11-03 04:24:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamiewalch@chromium.org/11359043/5001
8 years, 1 month ago (2012-11-03 07:15:11 UTC) #6
commit-bot: I haz the power
8 years, 1 month ago (2012-11-03 16:51:16 UTC) #7
Change committed as 165855

Powered by Google App Engine
This is Rietveld 408576698