content/browser/media/capture/web_contents_audio_input_stream_unittest.cc - Issue 1135823004: Implement all resolution change policies for desktop and tab capture.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/media/capture/web_contents_audio_input_stream_unittest.cc

Issue 1135823004: Implement all resolution change policies for desktop and tab capture. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@resolution_change_policy_constraints_ITEM1_CR1

Patch Set: Addressed Wez's third round comments. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/media/capture/web_contents_audio_input_stream.cc ('k') | content/browser/media/capture/web_contents_tracker.h » ('j') | content/browser/media/capture/web_contents_tracker.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/media/capture/web_contents_audio_input_stream_unittest.cc

diff --git a/content/browser/media/capture/web_contents_audio_input_stream_unittest.cc b/content/browser/media/capture/web_contents_audio_input_stream_unittest.cc

index ffe8b4b5d3f168dbece96d86e62767170770a8b4..0eebd7a8083b9fa10132fad36fb459ee26c05040 100644

--- a/content/browser/media/capture/web_contents_audio_input_stream_unittest.cc

+++ b/content/browser/media/capture/web_contents_audio_input_stream_unittest.cc

@@ -356,13 +356,7 @@ class WebContentsAudioInputStreamTest : public testing::Test {

private:

void SimulateChangeCallback(int render_process_id, int render_frame_id) {

ASSERT_FALSE(change_callback_.is_null());

- if (render_process_id == -1 || render_frame_id == -1) {

- change_callback_.Run(NULL);

- } else {

- // For our tests, any non-NULL value will suffice since it will not be

- // dereferenced.

- change_callback_.Run(reinterpret_cast<RenderWidgetHost*>(0xdeadbee5));

- }

+ change_callback_.Run(render_process_id != -1 && render_frame_id != -1);

}

scoped_ptr<TestBrowserThreadBundle> thread_bundle_;