content/browser/media/capture/web_contents_audio_input_stream.cc - Issue 1135823004: Implement all resolution change policies for desktop and tab capture.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/media/capture/web_contents_audio_input_stream.cc

Issue 1135823004: Implement all resolution change policies for desktop and tab capture. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@resolution_change_policy_constraints_ITEM1_CR1

Patch Set: Addressed Wez's third round comments. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/media/capture/desktop_capture_device_unittest.cc ('k') | content/browser/media/capture/web_contents_audio_input_stream_unittest.cc » ('j') | content/browser/media/capture/web_contents_tracker.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/media/capture/web_contents_audio_input_stream.cc

diff --git a/content/browser/media/capture/web_contents_audio_input_stream.cc b/content/browser/media/capture/web_contents_audio_input_stream.cc

index 629d1061f9f86f4763f7ecb6b514b64f0880995c..8fd1f976d59998ad91ecd67dc71de3b9f30a7193 100644

--- a/content/browser/media/capture/web_contents_audio_input_stream.cc

+++ b/content/browser/media/capture/web_contents_audio_input_stream.cc

@@ -91,7 +91,7 @@ class WebContentsAudioInputStream::Impl

// Called by WebContentsTracker when the target of the audio mirroring has

// changed.

- void OnTargetChanged(RenderWidgetHost* target);

+ void OnTargetChanged(bool had_target);

// Injected dependencies.

const int initial_render_process_id_;

@@ -305,11 +305,10 @@ void WebContentsAudioInputStream::Impl::ReleaseInput(

delete stream;

}

-void WebContentsAudioInputStream::Impl::OnTargetChanged(

- RenderWidgetHost* target) {

+void WebContentsAudioInputStream::Impl::OnTargetChanged(bool had_target) {

DCHECK(thread_checker_.CalledOnValidThread());

- is_target_lost_ = !target;

+ is_target_lost_ = !had_target;

if (state_ == MIRRORING) {

if (is_target_lost_) {