Android: Warning on license check fail.

Android: Warning on license check fail.

LIcense check is failing too frequenly, we should put it on the main builder/CQ.
Making the step failure a warning for now (it should not block tests).

BUG=160741
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=167469

[Yaron, 2012-11-13 17:45:32]

http://codereview.chromium.org/11358219/diff/4001/build/android/buildbot/buil...
File build/android/buildbot/buildbot_functions.sh (right):

http://codereview.chromium.org/11358219/diff/4001/build/android/buildbot/buil...
build/android/buildbot/buildbot_functions.sh:370: python
android_webview/tools/webview_licenses.py scan
Instead change this to:
bb_run_step python android_webview/tools/webview_licenses.py scan

and remove error handlng to avoid stopping the build. Although as you pointed
out offline, we should make sure it still runs tests

[Yaron, 2012-11-13 19:40:09]

lgtm

[Isaac (away), 2012-11-13 19:50:34]

lgtm.  There are several existing threads w/ android webview team for them to
improve / deprecate this scanner before we run it on CQ.  It's very slow the on
the trybots, so I am not willing to move it to CQ in its present state.

http://codereview.chromium.org/11358219/diff/4001/build/android/buildbot/buil...
File build/android/buildbot/buildbot_functions.sh (right):

http://codereview.chromium.org/11358219/diff/4001/build/android/buildbot/buil...
build/android/buildbot/buildbot_functions.sh:370: python
android_webview/tools/webview_licenses.py scan
On 2012/11/13 17:45:33, Yaron wrote:
> Instead change this to:
> bb_run_step python android_webview/tools/webview_licenses.py scan
> 
> and remove error handlng to avoid stopping the build. Although as you pointed
> out offline, we should make sure it still runs tests

We would need to change the bb_run_step function a bit to suppose "optional"
steps.  Probably easier to copy bb_run_step into a new function
"bb_run_fyi_step" that always uses STEP_WARNINGS instead of STEP_FAILURE.