Android: Warning on license check fail.

build/android/buildbot/buildbot_functions.sh

 #!/bin/bash
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 #
 # Bash functions used by buildbot annotator scripts for the android
 # build of chromium.  Executing this script should not perform actions
 # other than setting variables and defining of functions.
 
 # Number of jobs on the compile line; e.g.  make -j"${JOBS}"
@@ skipping 349 matching lines @@
   wait
   )
 }
 
 # Runs the license checker for the WebView build.
 function bb_check_webview_licenses {
   echo "@@@BUILD_STEP Check licenses for WebView@@@"
   (
   set +e
   cd "${SRC_ROOT}"
   python android_webview/tools/webview_licenses.py scan

[Yaron, 2012/11/13 17:45:33]

Instead change this to:
bb_run_step python android_webview/tools/webview_licenses.py scan

and remove error handlng to avoid stopping the build. Although as you pointed
out offline, we should make sure it still runs tests

[Isaac (away), 2012/11/13 19:50:34]

We would need to change the bb_run_step function a bit to suppose "optional"
steps.  Probably easier to copy bb_run_step into a new function
"bb_run_fyi_step" that always uses STEP_WARNINGS instead of STEP_FAILURE.

   if [[ $? -ne 0 ]]; then
-    echo "@@@STEP_FAILURE@@@"
+    echo "@@@STEP_WARNINGS@@@"
   fi
   return 0
   )
 }
 
 # Retrieve a packed json property using python
 function bb_get_json_prop {
   local JSON="$1"
   local PROP="$2"
 
   python -c "import json; print json.loads('$JSON').get('$PROP', '')"
 }