Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(64)

Issue 11358134: Fix for triple-slash dartdocs (Closed)

Created:
7 years, 9 months ago by strom
Modified:
7 years, 8 months ago
Reviewers:
Andrei Mouravski
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix for triple-slash dartdocs They had been ignoring multiline markdown such as code samples. More information available at: http://japhr.blogspot.com/2012/11/troubleshooting-triple-slash-dartdocs.html This also includes a new test file, though I am unsure if the paths are correct. BUG= Committed: https://code.google.com/p/dart/source/detail?r=15095

Patch Set 1 #

Total comments: 3

Patch Set 2 : Address code review comments #

Total comments: 1

Patch Set 3 : Indent multi-line string 2 more spaces. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -1 line) Patch
M sdk/lib/_internal/dartdoc/lib/src/dartdoc/comment_map.dart View 1 chunk +1 line, -1 line 0 comments Download
A sdk/lib/_internal/dartdoc/test/comment_map_test.dart View 1 2 1 chunk +38 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Andrei Mouravski
Looks awesome! Thanks for this change! I've added a few comments to this code review. ...
7 years, 9 months ago (2012-11-08 00:12:07 UTC) #1
Andrei Mouravski
Ping.
7 years, 9 months ago (2012-11-09 23:55:35 UTC) #2
Andrei Mouravski
On 2012/11/09 23:55:35, Andrei Mouravski wrote: > Ping. Hey again, Haven't heard back from you, ...
7 years, 9 months ago (2012-11-14 17:50:29 UTC) #3
strom
I incorporated all three suggestions into this updated patch.
7 years, 9 months ago (2012-11-16 04:12:53 UTC) #4
Andrei Mouravski
One small nit and you're almost good to go. http://codereview.chromium.org/11358134/diff/6001/sdk/lib/_internal/dartdoc/test/comment_map_test.dart File sdk/lib/_internal/dartdoc/test/comment_map_test.dart (right): http://codereview.chromium.org/11358134/diff/6001/sdk/lib/_internal/dartdoc/test/comment_map_test.dart#newcode23 sdk/lib/_internal/dartdoc/test/comment_map_test.dart:23: ...
7 years, 9 months ago (2012-11-16 16:43:56 UTC) #5
strom
Increased the indent by 2 more spaces. Thanks for the suggestion -- that looks much ...
7 years, 9 months ago (2012-11-16 17:05:56 UTC) #6
Andrei Mouravski
7 years, 9 months ago (2012-11-16 17:33:52 UTC) #7
lgtm

Great! Please sync from master, run tests again, and commit your changes.

Thanks for your contribution!

Powered by Google App Engine
This is Rietveld 408576698