cc/output/overlay_strategy_common.cc - Issue 1135813005: Add detection for rotation and flip overlay transforms

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/output/overlay_strategy_common.cc

Issue 1135813005: Add detection for rotation and flip overlay transforms (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Move Get*Axis to MathUtil, rename flipped->y_flipped Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/output/overlay_strategy_common.cc

diff --git a/cc/output/overlay_strategy_common.cc b/cc/output/overlay_strategy_common.cc

index b03fbba5fe2d52d1fa98f1d11ea3881e7f52b02f..be352a5130a270283f18bd7ff3e683ce9af6c15d 100644

--- a/cc/output/overlay_strategy_common.cc

+++ b/cc/output/overlay_strategy_common.cc

@@ -56,7 +56,8 @@ bool OverlayStrategyCommon::IsInvisibleQuad(const DrawQuad* draw_quad) {

bool OverlayStrategyCommon::GetTextureQuadInfo(const TextureDrawQuad& quad,

OverlayCandidate* quad_info) {

gfx::OverlayTransform overlay_transform =

- OverlayCandidate::GetOverlayTransform(quad.quadTransform(), quad.flipped);

+ OverlayCandidate::GetOverlayTransform(quad.quadTransform(),

+ quad.y_flipped);

if (quad.background_color != SK_ColorTRANSPARENT ||

quad.premultiplied_alpha ||

overlay_transform == gfx::OVERLAY_TRANSFORM_INVALID)

« cc/base/math_util.cc ('K') | « cc/output/overlay_candidate.cc ('k') | cc/output/overlay_unittest.cc » ('j') | cc/output/overlay_unittest.cc » ('J')