Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 11358123: Rewrite DefaultPrefStore for performance (Closed)

Created:
8 years, 1 month ago by aberent
Modified:
8 years, 1 month ago
CC:
chromium-reviews, erikwright+watch_chromium.org
Visibility:
Public.

Description

Rewrite DefaultPrefStore for performance Derive directly from PrefStore, and ignore observers since they can't usefully observe anything. Also remove now redundant members from ValueMapPrefStore. BUG=158330 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=166469

Patch Set 1 #

Total comments: 5

Patch Set 2 : Code review changes #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -28 lines) Patch
M base/prefs/default_pref_store.h View 1 2 chunks +13 lines, -2 lines 1 comment Download
M base/prefs/default_pref_store.cc View 1 2 chunks +17 lines, -2 lines 1 comment Download
M base/prefs/value_map_pref_store.h View 2 chunks +0 lines, -8 lines 0 comments Download
M base/prefs/value_map_pref_store.cc View 1 chunk +0 lines, -16 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Bernhard Bauer
lgtm https://codereview.chromium.org/11358123/diff/1/base/prefs/default_pref_store.cc File base/prefs/default_pref_store.cc (right): https://codereview.chromium.org/11358123/diff/1/base/prefs/default_pref_store.cc#newcode14 base/prefs/default_pref_store.cc:14: const const_iterator entry = prefs_.find(key); Nit: I think ...
8 years, 1 month ago (2012-11-06 18:25:02 UTC) #1
Mattias Nissler (ping if slow)
https://codereview.chromium.org/11358123/diff/1/base/prefs/default_pref_store.cc File base/prefs/default_pref_store.cc (right): https://codereview.chromium.org/11358123/diff/1/base/prefs/default_pref_store.cc#newcode14 base/prefs/default_pref_store.cc:14: const const_iterator entry = prefs_.find(key); On 2012/11/06 18:25:02, Bernhard ...
8 years, 1 month ago (2012-11-07 08:24:02 UTC) #2
Anthony Berent
https://codereview.chromium.org/11358123/diff/1/base/prefs/default_pref_store.cc File base/prefs/default_pref_store.cc (right): https://codereview.chromium.org/11358123/diff/1/base/prefs/default_pref_store.cc#newcode14 base/prefs/default_pref_store.cc:14: const const_iterator entry = prefs_.find(key); On 2012/11/07 08:24:02, Mattias ...
8 years, 1 month ago (2012-11-07 11:22:54 UTC) #3
Anthony Berent
Please review again - changed to use PrefValueMap
8 years, 1 month ago (2012-11-07 11:33:37 UTC) #4
battre
lgtm https://codereview.chromium.org/11358123/diff/5001/base/prefs/default_pref_store.cc File base/prefs/default_pref_store.cc (right): https://codereview.chromium.org/11358123/diff/5001/base/prefs/default_pref_store.cc#newcode6 base/prefs/default_pref_store.cc:6: #include "base/logging.h" not necessary https://codereview.chromium.org/11358123/diff/5001/base/prefs/default_pref_store.h File base/prefs/default_pref_store.h (right): ...
8 years, 1 month ago (2012-11-07 11:50:49 UTC) #5
Mattias Nissler (ping if slow)
LGTM
8 years, 1 month ago (2012-11-07 12:56:19 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aberent@chromium.org/11358123/5001
8 years, 1 month ago (2012-11-07 15:39:32 UTC) #7
commit-bot: I haz the power
8 years, 1 month ago (2012-11-07 18:06:03 UTC) #8
Change committed as 166469

Powered by Google App Engine
This is Rietveld 408576698