Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Side by Side Diff: base/prefs/value_map_pref_store.cc

Issue 11358123: Rewrite DefaultPrefStore for performance (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Code review changes Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/prefs/value_map_pref_store.h" 5 #include "base/prefs/value_map_pref_store.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 8
9 #include "base/stl_util.h" 9 #include "base/stl_util.h"
10 #include "base/values.h" 10 #include "base/values.h"
(...skipping 10 matching lines...) Expand all
21 } 21 }
22 22
23 void ValueMapPrefStore::RemoveObserver(PrefStore::Observer* observer) { 23 void ValueMapPrefStore::RemoveObserver(PrefStore::Observer* observer) {
24 observers_.RemoveObserver(observer); 24 observers_.RemoveObserver(observer);
25 } 25 }
26 26
27 size_t ValueMapPrefStore::NumberOfObservers() const { 27 size_t ValueMapPrefStore::NumberOfObservers() const {
28 return observers_.size(); 28 return observers_.size();
29 } 29 }
30 30
31 ValueMapPrefStore::iterator ValueMapPrefStore::begin() {
32 return prefs_.begin();
33 }
34
35 ValueMapPrefStore::iterator ValueMapPrefStore::end() {
36 return prefs_.end();
37 }
38
39 ValueMapPrefStore::const_iterator ValueMapPrefStore::begin() const {
40 return prefs_.begin();
41 }
42
43 ValueMapPrefStore::const_iterator ValueMapPrefStore::end() const {
44 return prefs_.end();
45 }
46
47 ValueMapPrefStore::~ValueMapPrefStore() {} 31 ValueMapPrefStore::~ValueMapPrefStore() {}
48 32
49 void ValueMapPrefStore::SetValue(const std::string& key, Value* value) { 33 void ValueMapPrefStore::SetValue(const std::string& key, Value* value) {
50 if (prefs_.SetValue(key, value)) 34 if (prefs_.SetValue(key, value))
51 FOR_EACH_OBSERVER(Observer, observers_, OnPrefValueChanged(key)); 35 FOR_EACH_OBSERVER(Observer, observers_, OnPrefValueChanged(key));
52 } 36 }
53 37
54 void ValueMapPrefStore::RemoveValue(const std::string& key) { 38 void ValueMapPrefStore::RemoveValue(const std::string& key) {
55 if (prefs_.RemoveValue(key)) 39 if (prefs_.RemoveValue(key))
56 FOR_EACH_OBSERVER(Observer, observers_, OnPrefValueChanged(key)); 40 FOR_EACH_OBSERVER(Observer, observers_, OnPrefValueChanged(key));
57 } 41 }
58 42
59 void ValueMapPrefStore::NotifyInitializationCompleted() { 43 void ValueMapPrefStore::NotifyInitializationCompleted() {
60 FOR_EACH_OBSERVER(Observer, observers_, OnInitializationCompleted(true)); 44 FOR_EACH_OBSERVER(Observer, observers_, OnInitializationCompleted(true));
61 } 45 }
OLDNEW
« base/prefs/default_pref_store.cc ('K') | « base/prefs/value_map_pref_store.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698