Chromium Code Reviews
Help | Chromium Project | Sign in
(89)

Issue 11358083: Decouple c/b/cros/audio from c/b/speech. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 5 months ago by erikwright
Modified:
2 years ago
Reviewers:
Jói
CC:
chromium-reviews, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Decouple c/b/cros/audio from c/b/speech. Introduce an initialization callback to decouple chrome/browser/chromeos/audio from chrome/browser/speech. R=joi@chromium.org BUG=TBD

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -39 lines) Patch
M chrome/browser/chromeos/audio/audio_handler.h View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/audio/audio_handler.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/audio/audio_mixer.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/audio/audio_mixer_alsa.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/audio/audio_mixer_alsa.cc View 5 chunks +14 lines, -13 lines 0 comments Download
M chrome/browser/chromeos/audio/audio_mixer_cras.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/audio/audio_mixer_cras.cc View 4 chunks +12 lines, -11 lines 0 comments Download
M chrome/browser/chromeos/chrome_browser_main_chromeos.cc View 2 chunks +2 lines, -1 line 0 comments Download
Trybot results:
Commit: CQ not working?

Messages

Total messages: 4 (0 generated)
erikwright
2 years, 5 months ago (2012-11-03 03:37:33 UTC) #1
Jói
LGTM
2 years, 5 months ago (2012-11-03 11:00:23 UTC) #2
erikwright
derat: PTAL.
2 years, 5 months ago (2012-11-06 23:37:52 UTC) #3
Daniel Erat
2 years, 5 months ago (2012-11-07 05:07:58 UTC) #4
lgtm

Thanks!
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 700cc9d