Issue 11358083: Decouple c/b/cros/audio from c/b/speech.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11358083: Decouple c/b/cros/audio from c/b/speech. (Closed)

Created:
8 years, 1 month ago by erikwright (departed)

Modified:
7 years, 8 months ago

Reviewers:
Jói

CC:
chromium-reviews, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Decouple c/b/cros/audio from c/b/speech. Introduce an initialization callback to decouple chrome/browser/chromeos/audio from chrome/browser/speech. R=joi@chromium.org BUG=TBD

Patch Set 1 #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+44 lines, -39 lines)			Patch
M	chrome/browser/chromeos/audio/audio_handler.h	View	3 chunks	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/audio/audio_handler.cc	View	3 chunks	+6 lines, -6 lines	0 comments	Download
M	chrome/browser/chromeos/audio/audio_mixer.h	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/audio/audio_mixer_alsa.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/chromeos/audio/audio_mixer_alsa.cc	View	5 chunks	+14 lines, -13 lines	0 comments	Download
M	chrome/browser/chromeos/audio/audio_mixer_cras.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/audio/audio_mixer_cras.cc	View	4 chunks	+12 lines, -11 lines	0 comments	Download
M	chrome/browser/chromeos/chrome_browser_main_chromeos.cc	View	2 chunks	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

lgtm

Thanks!

Expand Messages | Collapse Messages