src/animator/SkScriptRuntime.cpp - Issue 1135693003: Revert of Revert of stop calling SkScalarDiv

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/animator/SkScriptRuntime.cpp

Issue 1135693003: Revert of Revert of stop calling SkScalarDiv (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/animator/SkScriptRuntime.cpp

diff --git a/src/animator/SkScriptRuntime.cpp b/src/animator/SkScriptRuntime.cpp

index 78d9d5c2081b092506562c69796c5607ff4aa210..07bd4c9c2f1fa12881a5db8df963495b69e04049 100644

--- a/src/animator/SkScriptRuntime.cpp

+++ b/src/animator/SkScriptRuntime.cpp

@@ -249,7 +249,7 @@

operand[0].fScalar = operand[0].fScalar == 0 ? SK_ScalarNaN :

operand[0].fScalar > 0 ? SK_ScalarMax : -SK_ScalarMax;

else

- operand[0].fScalar = SkScalarDiv(operand[0].fScalar, operand[1].fScalar);

+ operand[0].fScalar = operand[0].fScalar / operand[1].fScalar;

break;

case SkScriptEngine2::kEqualInt:

operand[0].fS32 = operand[0].fS32 == operand[1].fS32;

« no previous file with comments | « src/animator/SkScript.cpp ('k') | src/core/SkGeometry.cpp » ('j') | no next file with comments »