src/animator/SkScript.cpp - Issue 1135693003: Revert of Revert of stop calling SkScalarDiv

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/animator/SkScript.cpp

Issue 1135693003: Revert of Revert of stop calling SkScalarDiv (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/animator/SkScript.cpp

diff --git a/src/animator/SkScript.cpp b/src/animator/SkScript.cpp

index 1d04d1b27630bafe162cf40f872f524ed8774521..c430695705d97aacab83ddb63e21182ceec5ccac 100644

--- a/src/animator/SkScript.cpp

+++ b/src/animator/SkScript.cpp

@@ -1387,7 +1387,7 @@

if (operand2.fScalar == 0)

operand2.fScalar = operand1.fScalar == 0 ? SK_ScalarNaN : operand1.fScalar > 0 ? SK_ScalarMax : -SK_ScalarMax;

else

- operand2.fScalar = SkScalarDiv(operand1.fScalar, operand2.fScalar);

+ operand2.fScalar = operand1.fScalar / operand2.fScalar;

break;

case kEqualInt:

operand2.fS32 = operand1.fS32 == operand2.fS32;

« no previous file with comments | « src/animator/SkDrawColor.cpp ('k') | src/animator/SkScriptRuntime.cpp » ('j') | no next file with comments »